Elasticsearch7 - search results don't show the owner of the page when owned by a group

[Dianne Tennent]

MySQL8+Firefox on main

To replicate:
1. Add a person to the site
2. Enable Elasticsearch 7, select all artefact types and index the site
3. Masquerade as the person you added
4. Click the search button without anything in the search field

Result:
 - About/Dashboard/Profile pages don't say whose they are

Expected:
 - When About/Dashboard/Profile page appears in search results, it should say whose page it is

[Dianne Tennent (dianne-t)]

This also happens in Postgres. In both MySQL and Postgres, it happens whether 'Show people in public search' is set to 'Yes' or 'No'

When I have 10 people plus admin on the site, there are 27 results under 'Text' which are mostly blank 'Documents' that are located on profile pages, dashboard pages or group homepages.

There is considerable repetition of results e.g. at least 6 results that all point to the same url: view/view.php?id=2. It looks like they are supposed to be pointing to a profile page, so that would be the wrong URL (as a profile page is /user/view.php?id=x). And there is the problem of not showing the person's name which is not very helpful in a result list of many profile/dashboard pages.

I've attached screenshots of my results and the error message.

[Dianne Tennent (dianne-t)]

Text of the error message, as the image isn't clear:

[WAR] e5 (lib/web.php:3602) redirect() should be called with either /[something] for local redirects or http[something] for absolute redirects
Call stack (most recent first):

    redirect() at /home/diannetennent/code/mahara2/htdocs/view/view.php:145

Mahara: Site unavailable
A nonrecoverable error occurred. This probably means you have encountered a bug in the system

[Dianne Tennent (dianne-t)]

The same thing happens on dev.mahara.org with Elasticsearch 5

[Kristina Hoeppner (kris-hoeppner)]

Only displaying 'Profile page' is normal because that's the title of the page.

The problem is that the author of the artefact is not displayed any more. It used to be, e.g. https://manual.mahara.org/en/21.10/misc/fulltextsearch.html#search-for-text (screenshot is from an older version though).

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13135

[Robert Lyon (robertl-9)]

This the patch fixes
- group pages not saying what group they are owned by
- lots of blocks just showing up as (Document) rather than with their block title

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13135
Committed: https://git.mahara.org/mahara/mahara/commit/873eff036d77bc68fa0cf0684281019e415ed9f6
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 873eff036d77bc68fa0cf0684281019e415ed9f6
Author: Robert Lyon <email address hidden>
Date: Tue Sep 6 11:04:17 2022 +1200

Bug 1970358: Adding group ownership name to pages / collections

In elasticsearch/ES7 results

Change-Id: I6655c59788ce731a3ff4ba4b83bf2819d02fd5da
Signed-off-by: Robert Lyon <email address hidden>