Check for affiliated emails whenever logging in via SAML if option is set

Bug #1966363 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Robert Lyon

Bug Description

When a new person is created via saml login and they have affiliated emails coming thru then all the emails are added to the person along with the one in the 'email' option and the one that is made primary will be the one that comes from the affiliation where their permission is highest.

But when they log in again their affiliated emails are ignored.

This would be fine if all people only ever logged in after the change.

But if there are existing people in the site then they never get their affiliated emails

We need to do some logic for updating existing people on SAML login

Tags: newfeature
Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 22.04.0
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12516

Changed in mahara:
importance: Medium → Wishlist
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12516
Committed: https://git.mahara.org/mahara/mahara/commit/d7904aa4a72b44fccc021228aea7b671e69f452a
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit d7904aa4a72b44fccc021228aea7b671e69f452a
Author: Robert Lyon <email address hidden>
Date: Fri Mar 25 12:09:29 2022 +1300

Bug 1966363 - Allow for affiliated emails be added on 2nd login

When we do the update steps rather then create steps
- Adds any email that doesn't already exist
- Makes sure the primary email stays the same before as long as
the primary email is one of the current affiliated ones otherwise
defaults back to what is in 'email' field

Change-Id: I120e39224533cdae19f7114ee16a6c39d2bae527
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: newfeature
summary: - The SAML change for affiliated emails not working correctly
+ Check for affiliated emails whenever logging in via SAML if option is
+ set
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.