Needing to respect the default layout mode of a page

Bug #1959733 reported by Robert Lyon
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
20.10
Fix Released
High
Unassigned
21.04
Fix Released
High
Unassigned
21.10
Fix Released
High
Unassigned
22.04
Fix Released
High
Unassigned

Bug Description

When we make a page in a desktop browser (gridstack desktop mode) and then edit the page on a mobile browser (gridstack mobile mode) it mucks up the layout of the page and makes all the blocks have width = 1.

We need to do the following:
1 Page created in desktop but changes made in mobile: Keep desktop width dimensions.
2. New page created in mobile: Set the default width to the default desktop width instead of
using width=1 column.
3. In Mobile: When to block configuration is updated by clicking the 'Save' button, don't change the block dimension, but leave it on what is there. Only change the block dimension when the block
is actively resized on mobile, but not when block content is save

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12384

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12396

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12384
Committed: https://git.mahara.org/mahara/mahara/commit/48ad6e5f29bf27327028646124cdd9c1cc1981b3
Submitter: Gold (<email address hidden>)
Branch: main

commit 48ad6e5f29bf27327028646124cdd9c1cc1981b3
Author: Robert Lyon <email address hidden>
Date: Wed Jan 19 14:25:39 2022 +1300

Bug 1959733: Adjusting gridstack for mobile

So that when editing a page in mobile mode for a page that was
originally made in desktop mode we don't save the block width as width
= 1 as this mucks up the page in desktop mode.

Change-Id: I85ee39b444ea5c460119f183f4f35a6f20edf9a8
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12396
Committed: https://git.mahara.org/mahara/mahara/commit/37161791ca17c054e11b292bee2c46aecb86dff8
Submitter: Gold (<email address hidden>)
Branch: main

commit 37161791ca17c054e11b292bee2c46aecb86dff8
Author: Robert Lyon <email address hidden>
Date: Fri Feb 4 12:21:24 2022 +1300

Bug 1959733: Allowing old pages with broken layout update to gridstack

This is where the column value for a block is greater than the number
of columns for that row

Change-Id: Id1c321ca13abbb771767f7a3494db2612845ff9f
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12406

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12405

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12408

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12407

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12409

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12410

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12411

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12411
Committed: https://git.mahara.org/mahara/mahara/commit/676fede182c110bdc649ed018d6b0bb2ff2ca57b
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 676fede182c110bdc649ed018d6b0bb2ff2ca57b
Author: Robert Lyon <email address hidden>
Date: Wed Feb 9 11:03:00 2022 +1300

Bug 1959733: Upgrade step fix for postgres

Turns out it's not very smary with rserved words

Change-Id: Id82d3d9b336063475c3e8f938d8391e8ec30147d
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12412

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12413

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12414

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12410
Committed: https://git.mahara.org/mahara/mahara/commit/8acbec4ca8004f1f49614952f11d25cfe69e5770
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 8acbec4ca8004f1f49614952f11d25cfe69e5770
Author: Robert Lyon <email address hidden>
Date: Fri Feb 4 12:21:24 2022 +1300

Bug 1959733: Allowing old pages with broken layout update to gridstack

This is where the column value for a block is greater than the number
of columns for that row

Change-Id: Id1c321ca13abbb771767f7a3494db2612845ff9f
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12409
Committed: https://git.mahara.org/mahara/mahara/commit/7000bacaf1e99e3978d4bebacaf0575ff85dd260
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 7000bacaf1e99e3978d4bebacaf0575ff85dd260
Author: Robert Lyon <email address hidden>
Date: Wed Jan 19 14:25:39 2022 +1300

Bug 1959733: Adjusting gridstack for mobile

So that when editing a page in mobile mode for a page that was
originally made in desktop mode we don't save the block width as width
= 1 as this mucks up the page in desktop mode.

Change-Id: I85ee39b444ea5c460119f183f4f35a6f20edf9a8
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12414
Committed: https://git.mahara.org/mahara/mahara/commit/977b19b5ec0f56674d08f41845202ef97a255bac
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 977b19b5ec0f56674d08f41845202ef97a255bac
Author: Robert Lyon <email address hidden>
Date: Wed Feb 9 11:03:00 2022 +1300

Bug 1959733: Upgrade step fix for postgres

Turns out it's not very smary with rserved words

Change-Id: Id82d3d9b336063475c3e8f938d8391e8ec30147d
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12405
Committed: https://git.mahara.org/mahara/mahara/commit/6a011dd80550ff439f73cc6b492bfe94dec452e2
Submitter: Gold (<email address hidden>)
Branch: 20.10_DEV

commit 6a011dd80550ff439f73cc6b492bfe94dec452e2
Author: Robert Lyon <email address hidden>
Date: Wed Jan 19 14:25:39 2022 +1300

Bug 1959733: Adjusting gridstack for mobile

So that when editing a page in mobile mode for a page that was
originally made in desktop mode we don't save the block width as width
= 1 as this mucks up the page in desktop mode.

Change-Id: I85ee39b444ea5c460119f183f4f35a6f20edf9a8
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12406
Committed: https://git.mahara.org/mahara/mahara/commit/24cdeca063776ad03fad68d0e9dc94835b55a140
Submitter: Gold (<email address hidden>)
Branch: 20.10_DEV

commit 24cdeca063776ad03fad68d0e9dc94835b55a140
Author: Robert Lyon <email address hidden>
Date: Fri Feb 4 12:21:24 2022 +1300

Bug 1959733: Allowing old pages with broken layout update to gridstack

This is where the column value for a block is greater than the number
of columns for that row

Change-Id: Id1c321ca13abbb771767f7a3494db2612845ff9f
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12412
Committed: https://git.mahara.org/mahara/mahara/commit/80a284c125a981dda53bbe9be2c5d26caf7d7ac4
Submitter: Gold (<email address hidden>)
Branch: 20.10_DEV

commit 80a284c125a981dda53bbe9be2c5d26caf7d7ac4
Author: Robert Lyon <email address hidden>
Date: Wed Feb 9 11:03:00 2022 +1300

Bug 1959733: Upgrade step fix for postgres

Turns out it's not very smary with rserved words

Change-Id: Id82d3d9b336063475c3e8f938d8391e8ec30147d
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12407
Committed: https://git.mahara.org/mahara/mahara/commit/29adc49ac0024cd7657f1718b5af825ee39c1859
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 29adc49ac0024cd7657f1718b5af825ee39c1859
Author: Robert Lyon <email address hidden>
Date: Wed Jan 19 14:25:39 2022 +1300

Bug 1959733: Adjusting gridstack for mobile

So that when editing a page in mobile mode for a page that was
originally made in desktop mode we don't save the block width as width
= 1 as this mucks up the page in desktop mode.

Change-Id: I85ee39b444ea5c460119f183f4f35a6f20edf9a8
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12408
Committed: https://git.mahara.org/mahara/mahara/commit/c429eb3ef6e003e0a974bb14e4d9cf74941a9737
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit c429eb3ef6e003e0a974bb14e4d9cf74941a9737
Author: Robert Lyon <email address hidden>
Date: Fri Feb 4 12:21:24 2022 +1300

Bug 1959733: Allowing old pages with broken layout update to gridstack

This is where the column value for a block is greater than the number
of columns for that row

Change-Id: Id1c321ca13abbb771767f7a3494db2612845ff9f
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12413
Committed: https://git.mahara.org/mahara/mahara/commit/9868057950c5b71cb71f8bf7e5dc941a39b14ea2
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 9868057950c5b71cb71f8bf7e5dc941a39b14ea2
Author: Robert Lyon <email address hidden>
Date: Wed Feb 9 11:03:00 2022 +1300

Bug 1959733: Upgrade step fix for postgres

Turns out it's not very smary with rserved words

Change-Id: Id82d3d9b336063475c3e8f938d8391e8ec30147d
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.