Upload CSV Users Bug with Failed Emails
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
High
|
Unassigned | ||
| 20.10 |
Fix Released
|
High
|
Unassigned | ||
| 21.04 |
Fix Released
|
High
|
Unassigned | ||
| 21.10 |
Fix Released
|
High
|
Unassigned | ||
| 22.04 |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Mahara: 21.10.0
OS: Linux 20.04
DB: Postgres
Browser: n/a
While implementing a customisation for a client, we identified a very old bug in htdocs/
The setting of the `$failedusers` array on line 639 occurs within the foreach loop. Which means, the data in the $failedusers array gets reset after each iteration.
The initialisation of $failedusers should occur outside of the foreach loop.
https:/
This is the current code at line 637:
if ($values[
foreach ($addedusers as $user) {
try {
...
It should be:
if ($values[
foreach ($addedusers as $user) {
try {
...
Hope that makes sense.
Thank you.
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #2 |
| Robert Lyon (robertl-9) wrote | #1 |
| Mahara Bot (dev-mahara) wrote A change has been merged | #3 |
| Changed in mahara: | |
| status: | New → Fix Committed |
| milestone: | none → 22.04.0 |
| importance: | Undecided → High |
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #4 |
| Mahara Bot (dev-mahara) wrote | #5 |
| Mahara Bot (dev-mahara) wrote | #6 |
| Mahara Bot (dev-mahara) wrote A change has been merged | #7 |
| Mahara Bot (dev-mahara) wrote | #8 |
| Mahara Bot (dev-mahara) wrote | #9 |
Patch for "main" branch: https:/