Cannot share portfolio after it has been submitted

[Dianne Tennent]

Environment: main branch, postgres, Firefox+Chromium

Steps to reproduce:
1. Create a controlled group that allows submissions
2. Masquerade as a member of the group
3. Submit a page for group assessment group from the group's home page. (Not from 'Pages and collections')
4. Return to the page you submitted, click 'Manage access'
5. Share with a person, admin account

Expected outcome:
Portfolio is able to be shared with admin account

Actual outcome:
Access denied error: You do not have access to view this page.
You cannot edit this page because it has been submitted for assessment to "Submissions Testing". You will have to wait until a tutor releases the page.

Note: people should be able to share their portfolios even after they have been submitted.

[Kristina Hoeppner (kris-hoeppner)]

The problem is not the access permissions. When you go to 'Shared by me' you can see that the portfolio was shared successfully. The error message comes about because when you give access while you are editing the page, you are being redirected to the 'Edit' screen, which is correctly not available while the portfolio is submitted. Instead, the portfolio author should probably be best redirected to the 'Display' mode of the page to prevent this problem.

[Kristina Hoeppner (kris-hoeppner)]

The solution:

1. When you click the 'Manage access' option while you are in 'Display' mode of a page, on saving the access permissions, you should be redirected to the 'Display' mode, i.e. view.php.

2. No change: When you are in 'Edit' mode and click 'Manage access' and you change permissions, you should be redirected to 'Edit' mode.

3. When you are on the 'Pages and collections' overview page and click the 'Manage access' icon for a page or collection, finish with permissions, you should be redirected to the 'Pages and collections' overview page.

4. No change: When you are on 'Shared by me' and share a portfolio, you'll be redirected to 'Shared by me'.

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12601

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12601
Committed: https://git.mahara.org/mahara/mahara/commit/10d02038e6270d304e11c3fd241606b7feec414d
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 10d02038e6270d304e11c3fd241606b7feec414d
Author: Dianne Tennent <email address hidden>
Date: Thu Apr 14 14:38:19 2022 +1200

Bug 1957721: redirect after managing access permissions

Redirect to where you started from after saving new
access permissions, with confirmation message.

Change-Id: Ie7537e323b55f0ccac6db9e52d510320bafa5188

[Mahara Bot (dev-mahara)]

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/12576

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12576
Committed: https://git.mahara.org/mahara/mahara/commit/3082d23160fc13aea9c470ad348ca9e63262a7a5
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 3082d23160fc13aea9c470ad348ca9e63262a7a5
Author: Dianne Tennent <email address hidden>
Date: Thu Apr 14 14:38:19 2022 +1200

Bug 1957721: redirect after managing access permissions

Redirect to where you started from after saving new
access permissions, with confirmation message.

Change-Id: Ie7537e323b55f0ccac6db9e52d510320bafa5188
(cherry picked from commit 10d02038e6270d304e11c3fd241606b7feec414d)

[Mahara Bot (dev-mahara)]

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/12578

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12578
Committed: https://git.mahara.org/mahara/mahara/commit/ff69e913e9d4a8406bed8b8dad53012c84393d49
Submitter: "Doris Tam <email address hidden>"
Branch: 21.10_DEV

commit ff69e913e9d4a8406bed8b8dad53012c84393d49
Author: Dianne Tennent <email address hidden>
Date: Thu Apr 14 14:38:19 2022 +1200

Bug 1957721: redirect after managing access permissions

Redirect to where you started from after saving new
access permissions, with confirmation message.

Change-Id: Ie7537e323b55f0ccac6db9e52d510320bafa5188
(cherry picked from commit 10d02038e6270d304e11c3fd241606b7feec414d)

[Mahara Bot (dev-mahara)]

Patch for "21.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/12579

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12579
Committed: https://git.mahara.org/mahara/mahara/commit/f7ec65718bbb4a513a9bac4fe67ce69070311967
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.04_DEV

commit f7ec65718bbb4a513a9bac4fe67ce69070311967
Author: Dianne Tennent <email address hidden>
Date: Thu Apr 14 14:38:19 2022 +1200

Bug 1957721: redirect after managing access permissions

Redirect to where you started from after saving new
access permissions, with confirmation message.

Change-Id: Ie7537e323b55f0ccac6db9e52d510320bafa5188
(cherry picked from commit 10d02038e6270d304e11c3fd241606b7feec414d)