Formatted time includes extra space before the hour digit in submission notification

Bug #1957720 reported by Dianne Tennent
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Confirmed
Low
Unassigned

Bug Description

Environment:
Main branch, both Chromium and Firefox

Steps to reproduce:
1. Create a controlled group that allows submissions
2. Masquerade as a member of the group
3. Submit a page to the group
4. View the notification that comes through in Mahara notifications to the group member

Currently coming through as the following (See the double space between 'January 2022,' and '2:13pm':
"This is to confirm that you submitted the page "Untitled v.2" successfully to 'Submissions Testing' at 13 January 2022, 2:13pm.

If you have any questions about this submission, please contact your instructor."

However, if the hour is a double digit i.e. 10, 11 or 12, this extra space doesn't seem to be added.

Date formatting is happening in htdocs/module/assessmentreport/lib.php lines 129/132

Desired outcome: remove the extra space

Revision history for this message
Dianne Tennent (dianne-t) wrote :

Just updating this to add the comments from community members on the forum post I made on Oct 22, 2021: https://mahara.org/interaction/forum/topic.php?id=8940

"Just a quick comment to say yes I'm completely in favour of the concept. Anything that clarifies the purpose of a button or feature and gives people a more instinctive understanding of how to do things can only be good, and sometimes simple changes like expressly saying "go to your portfolio pages" or "create new content" can have a surprisingly big impact. Please keep the suggestions coming!"

"Just to say I agree - both suggestions are a great step forward! Perhaps it could coincide with a rethink of what's on the Dashboard too? The 'Create' tile takes you to your 'Pages and Collections' page."

Changed in mahara:
importance: Undecided → Low
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.