Dealing with function/class parameter Phpstan errors

Bug #1953396 reported by Dianne Tennent
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned

Bug Description

Fixing syntax errors in preparation for PHP8 upgrade. This patch does not include 3rd party libraries.

e.g. Class SystemException constructor invoked with 0 parameters, 1-2 required.

e.g. Parameter #1 $parser of method dbQuerySet::_tag_close() is not passed by reference but parameter #1 $parser of method dbObject::_tag_close() is passed by reference.

These can be verified by running;
phpstan analyse htdocs

And searching for "parameter" and "parameters"

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12289

summary: - Dealing with function parameters Phpstan errors
+ Dealing with function/class parameters Phpstan errors
summary: - Dealing with function/class parameters Phpstan errors
+ Dealing with function/class parameter Phpstan errors
description: updated
Changed in mahara:
status: New → In Progress
importance: Undecided → High
milestone: none → 22.04.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers