PHP warnings on menu->share->submissions and related issues

Bug #1952771 reported by Alexander Del Ponte
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 22.04
21.04
High
Unassigned
21.10
High
Unassigned
22.04
High
Unassigned

Bug Description

Listing all submissions a user is involved via menu->share->submissions causes PHP-warnings and several content issues referring to the assessor column resp. missing entries.

In combination to that issue there are massive DB accesses which can result in large time delays displaying the table especially if the user is assessor in multiple groups.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Patch at https://reviews.mahara.org/#/c/12280/

Associated forum conversation with some more details around testing: https://mahara.org/interaction/forum/topic.php?id=8942

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12319

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12280
Committed: https://git.mahara.org/mahara/mahara/commit/3f375a42de23ed8fd2344c2ff602b48716bdcb45
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 3f375a42de23ed8fd2344c2ff602b48716bdcb45
Author: Alexander Del Ponte <email address hidden>
Date: Tue Nov 30 16:21:28 2021 +0100

Bug 1952771: Fix PHP warnings for submissions

When portfolios are deleted, don't show error any more
in Main menu -> Share -> Submissions.

Also optimised DB access and feedback related issues.

Change-Id: I1ba68e81073cf3fd24cd202b8caae51845a56754

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12319
Committed: https://git.mahara.org/mahara/mahara/commit/c0555833d8bbf37e35ef5ae676489a8b2b446631
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit c0555833d8bbf37e35ef5ae676489a8b2b446631
Author: Robert Lyon <email address hidden>
Date: Wed Dec 22 16:54:27 2021 +1300

Bug 1952771: Allow the system to use full_name function again

The other patch for this bug reverted functionality that core
Mahara requires in regards to the full_name function rather
than use a customisation that doesn't follow Mahara conventions
and thus would make it harder to troubleshoot.

Change-Id: I5a900afb0168076ca0684cdca7acad86e97fe147
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12339

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12340

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12341

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12342

Robert Lyon (robertl-9)
no longer affects: mahara/20.10
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12340
Committed: https://git.mahara.org/mahara/mahara/commit/4c7546a485aeb9ea78431fca38ed7320e3bff3ff
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 4c7546a485aeb9ea78431fca38ed7320e3bff3ff
Author: Alexander Del Ponte <email address hidden>
Date: Tue Nov 30 16:21:28 2021 +0100

Bug 1952771: Fix PHP warnings for submissions

When portfolios are deleted, don't show error any more
in Main menu -> Share -> Submissions.

Also optimised DB access and feedback related issues.

Change-Id: I1ba68e81073cf3fd24cd202b8caae51845a56754
(cherry picked from commit 3f375a42de23ed8fd2344c2ff602b48716bdcb45)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12342
Committed: https://git.mahara.org/mahara/mahara/commit/fd0d9d1bf4c63a642dc5db3c04c3ab496c664da3
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit fd0d9d1bf4c63a642dc5db3c04c3ab496c664da3
Author: Robert Lyon <email address hidden>
Date: Wed Dec 22 16:54:27 2021 +1300

Bug 1952771: Allow the system to use full_name function again

The other patch for this bug reverted functionality that core
Mahara requires in regards to the full_name function rather
than use a customisation that doesn't follow Mahara conventions
and thus would make it harder to troubleshoot.

Change-Id: I5a900afb0168076ca0684cdca7acad86e97fe147
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12339
Committed: https://git.mahara.org/mahara/mahara/commit/995a50d6340b1b78f47c354a3b5e3d9c02d3eaa9
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 995a50d6340b1b78f47c354a3b5e3d9c02d3eaa9
Author: Alexander Del Ponte <email address hidden>
Date: Tue Nov 30 16:21:28 2021 +0100

Bug 1952771: Fix PHP warnings for submissions

When portfolios are deleted, don't show error any more
in Main menu -> Share -> Submissions.

Also optimised DB access and feedback related issues.

Change-Id: I1ba68e81073cf3fd24cd202b8caae51845a56754
(cherry picked from commit 3f375a42de23ed8fd2344c2ff602b48716bdcb45)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12341
Committed: https://git.mahara.org/mahara/mahara/commit/d07dd7c42c20f466a0b73bd564ed3119c2f6977b
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit d07dd7c42c20f466a0b73bd564ed3119c2f6977b
Author: Robert Lyon <email address hidden>
Date: Wed Dec 22 16:54:27 2021 +1300

Bug 1952771: Allow the system to use full_name function again

The other patch for this bug reverted functionality that core
Mahara requires in regards to the full_name function rather
than use a customisation that doesn't follow Mahara conventions
and thus would make it harder to troubleshoot.

Change-Id: I5a900afb0168076ca0684cdca7acad86e97fe147
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers