Blocks are not hidden properly with Gridstack

Bug #1951016 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 22.04
20.10
High
Unassigned
21.04
High
Unassigned
21.10
High
Unassigned
22.04
High
Unassigned

Bug Description

When blocks re on a page but then the associated plugin is hidden, the blocks are not hidden properly from the pages and may produce error messages.

To replicate:

1. Add a couple of people to your Mahara instance.
2. Hide the 'Wall' and 'My friends' blocks in the plugin administration.

Expected result: They are not visible on the profile page.
Actual result: They can still be seen.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12250

Revision history for this message
Robert Lyon (robertl-9) wrote :

The patch handles the following scenarios

When a block type is set to hidden (inactive) on the plugins page then:

1) The instances of the block type should not show when viewing / editing a page

2) The instances of the block type do show when viewing the page in timeline (versioning mode) as we are unable to know when the block type was made inactive.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12250
Committed: https://git.mahara.org/mahara/mahara/commit/d9177ea448209f6683ba14a9387994034f92b1ac
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit d9177ea448209f6683ba14a9387994034f92b1ac
Author: Robert Lyon <email address hidden>
Date: Mon Nov 8 10:02:24 2021 +1300

Bug 1951016: Blocks not being turned off on gridstack pages

When a blocktype is set to hidden (inactive) on the plugins page then
instances of the blocktype should not show on pages anymore unless we
are in versioning mode

Change-Id: I9901e18cc84a102227f4e75b57d0d84f838c6644
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12251

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12252

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12253

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12256

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12256
Committed: https://git.mahara.org/mahara/mahara/commit/a9412ee70fa2b73647c704fba6ffc66a5f4cb930
Submitter: Gold (<email address hidden>)
Branch: main

commit a9412ee70fa2b73647c704fba6ffc66a5f4cb930
Author: Robert Lyon <email address hidden>
Date: Fri Nov 19 10:24:07 2021 +1300

Bug 1951016: fixing misplaced JOIN statement

Change-Id: I97bf2c3878882fd78e702ae39d86e706cb9034fa
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12251
Committed: https://git.mahara.org/mahara/mahara/commit/cadfb8b693c7f03d5a504eeeace43650c7d6e8ca
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit cadfb8b693c7f03d5a504eeeace43650c7d6e8ca
Author: Robert Lyon <email address hidden>
Date: Mon Nov 8 10:02:24 2021 +1300

Bug 1951016: Blocks not being turned off on gridstack pages

When a blocktype is set to hidden (inactive) on the plugins page then
instances of the blocktype should not show on pages anymore unless we
are in versioning mode

Change-Id: I9901e18cc84a102227f4e75b57d0d84f838c6644
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d9177ea448209f6683ba14a9387994034f92b1ac)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12253
Committed: https://git.mahara.org/mahara/mahara/commit/98b850c545a331817f771c88d6bfdd889e1de4bc
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_DEV

commit 98b850c545a331817f771c88d6bfdd889e1de4bc
Author: Robert Lyon <email address hidden>
Date: Mon Nov 8 10:02:24 2021 +1300

Bug 1951016: Blocks not being turned off on gridstack pages

When a blocktype is set to hidden (inactive) on the plugins page then
instances of the blocktype should not show on pages anymore unless we
are in versioning mode

Change-Id: I9901e18cc84a102227f4e75b57d0d84f838c6644
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d9177ea448209f6683ba14a9387994034f92b1ac)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12252
Committed: https://git.mahara.org/mahara/mahara/commit/718509cfdbe6602e5a1cb1c086085fac88543040
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 718509cfdbe6602e5a1cb1c086085fac88543040
Author: Robert Lyon <email address hidden>
Date: Mon Nov 8 10:02:24 2021 +1300

Bug 1951016: Blocks not being turned off on gridstack pages

When a blocktype is set to hidden (inactive) on the plugins page then
instances of the blocktype should not show on pages anymore unless we
are in versioning mode

Change-Id: I9901e18cc84a102227f4e75b57d0d84f838c6644
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d9177ea448209f6683ba14a9387994034f92b1ac)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers