Gallery thumbnail popup has alternate slideshow but shouldn't have this

Bug #1950551 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Unassigned

Bug Description

We have a bootstrap slideshow so we don't need another one in the gallery thumbnails as part of the image popup.

We should instead use the bootstrap modal for the popups in the gallery thumbnails.

To test, before patch:

Add a gallery with square-thumbs chosen.

Display the page and click on an image in the gallery

The popup has a play button in it.

After the patch:

The popup is just a modal popup now

Tags: newfeature
Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 22.04.0
status: New → In Progress
importance: Undecided → Wishlist
Revision history for this message
Robert Lyon (robertl-9) wrote :

Part of the testing should include:

1) Putting descriptions on some of the images and turning on 'show descriptions' in the gallery block config

2) Looking at the modal popup in different layout sizes

3) Large image vs small images

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12132
Committed: https://git.mahara.org/mahara/mahara/commit/0d6d54d864ba27965b143835b84804c4ad7b5fc5
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 0d6d54d864ba27965b143835b84804c4ad7b5fc5
Author: Robert Lyon <email address hidden>
Date: Fri Oct 8 16:59:46 2021 +1300

Bug 1950551: changing the non-carousel gallery to just use a modal popup

Change-Id: Id67fc5579e87e8a9634cc1c2cd0e69dc96407802
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: newfeature
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.