Call to protected method webservice_base_server::session_cleanup() from context

Bug #1950220 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 22.04
20.10
High
Unassigned
21.04
High
Unassigned
21.10
High
Unassigned
22.04
High
Unassigned

Bug Description

The module/mobileapi/download.php file is trying to call the session_cleanup() method outside of the class itself.

Need to do this call from within the class via $this object

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12235

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12235
Committed: https://git.mahara.org/mahara/mahara/commit/4572a5ebfb86adcaf03541f70b9793d616ae2694
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 4572a5ebfb86adcaf03541f70b9793d616ae2694
Author: Robert Lyon <email address hidden>
Date: Tue Nov 9 12:09:35 2021 +1300

Bug 1950220: Call session_cleanup() correctly for mobile

Change-Id: Icce22cae8acaffeb3b8bebd282bcfaf5f9317473
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12239

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12240

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12241

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12239
Committed: https://git.mahara.org/mahara/mahara/commit/2f297ff47cd92f25fbd1841c08cd8e86c4787e5f
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 2f297ff47cd92f25fbd1841c08cd8e86c4787e5f
Author: Robert Lyon <email address hidden>
Date: Tue Nov 9 12:09:35 2021 +1300

Bug 1950220: Call session_cleanup() correctly for mobile

Change-Id: Icce22cae8acaffeb3b8bebd282bcfaf5f9317473
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4572a5ebfb86adcaf03541f70b9793d616ae2694)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12240
Committed: https://git.mahara.org/mahara/mahara/commit/c20501d38083236d24dddb48e07a881d0904003b
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit c20501d38083236d24dddb48e07a881d0904003b
Author: Robert Lyon <email address hidden>
Date: Tue Nov 9 12:09:35 2021 +1300

Bug 1950220: Call session_cleanup() correctly for mobile

Change-Id: Icce22cae8acaffeb3b8bebd282bcfaf5f9317473
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4572a5ebfb86adcaf03541f70b9793d616ae2694)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12241
Committed: https://git.mahara.org/mahara/mahara/commit/55e794d79dff95837c5838a289f7765f7938721a
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_DEV

commit 55e794d79dff95837c5838a289f7765f7938721a
Author: Robert Lyon <email address hidden>
Date: Tue Nov 9 12:09:35 2021 +1300

Bug 1950220: Call session_cleanup() correctly for mobile

Change-Id: Icce22cae8acaffeb3b8bebd282bcfaf5f9317473
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4572a5ebfb86adcaf03541f70b9793d616ae2694)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers