Styles missing in new collapsed comments section

Bug #1950068 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 22.04
20.10
High
Unassigned
21.04
High
Unassigned
21.10
High
Unassigned
22.04
High
Evonne Cheung

Bug Description

This issue was introduced in Mahara 21.10. When you have threaded comments turned on, you can't distinguish the indentation for replies easily any more as there is no colour difference.

See the attached image vs. the screenshot at https://manual.mahara.org/en/21.04/portfolio/feedback.html#view-page-comments : In 21.04 the background distinguished indented comments, whereas now there is no background to do so.

To replicate:

1. Allow 'Threaded comments' in the institution settings.
2. Create a page (make sure you are a member of the institution) and allow comments on the page.
3. Add a public comment.
4. Log in as sb else and reply to the comment.

Expected result: The comment is indented and visually distinguished from the one you reply to.
Actual result: The comment is indented, but there is no background change. Everything is still white.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12234

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12234
Committed: https://git.mahara.org/mahara/mahara/commit/ce8aecd3ec9cbacfe521d9bbb687c3fa0b164189
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit ce8aecd3ec9cbacfe521d9bbb687c3fa0b164189
Author: Evonne <email address hidden>
Date: Tue Nov 9 11:29:22 2021 +1300

Bug 1950068 styles for threaded comments

Changed the calculation to be the border-left width instead as
putting in background but provides the same visual cue.

behatnotneeded

Change-Id: I9ef24c8a7488545f82d008e90695c7858dc9245a

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12260

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12261

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12262

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12260
Committed: https://git.mahara.org/mahara/mahara/commit/7103dca3f632392a98892c91b26f93e829a075ba
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 7103dca3f632392a98892c91b26f93e829a075ba
Author: Evonne <email address hidden>
Date: Tue Nov 9 11:29:22 2021 +1300

Bug 1950068 styles for threaded comments

Changed the calculation to be the border-left width instead as
putting in background but provides the same visual cue.

behatnotneeded

Change-Id: I9ef24c8a7488545f82d008e90695c7858dc9245a
(cherry picked from commit ce8aecd3ec9cbacfe521d9bbb687c3fa0b164189)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12262
Committed: https://git.mahara.org/mahara/mahara/commit/7aca9c7d8113f96d03e245c52afc7607f1b4e0ed
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_DEV

commit 7aca9c7d8113f96d03e245c52afc7607f1b4e0ed
Author: Evonne <email address hidden>
Date: Tue Nov 9 11:29:22 2021 +1300

Bug 1950068 styles for threaded comments

Changed the calculation to be the border-left width instead as
putting in background but provides the same visual cue.

behatnotneeded

Change-Id: I9ef24c8a7488545f82d008e90695c7858dc9245a
(cherry picked from commit ce8aecd3ec9cbacfe521d9bbb687c3fa0b164189)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12261
Committed: https://git.mahara.org/mahara/mahara/commit/8b642ceb252d75125ec56e2b12e53b8902929a86
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 8b642ceb252d75125ec56e2b12e53b8902929a86
Author: Evonne <email address hidden>
Date: Tue Nov 9 11:29:22 2021 +1300

Bug 1950068 styles for threaded comments

Changed the calculation to be the border-left width instead as
putting in background but provides the same visual cue.

behatnotneeded

Change-Id: I9ef24c8a7488545f82d008e90695c7858dc9245a
(cherry picked from commit ce8aecd3ec9cbacfe521d9bbb687c3fa0b164189)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers