Wrong language used when requesting sb else's comment to be made public

Bug #1950067 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 22.04
21.10
High
Unassigned
22.04
High
Doris Tam

Bug Description

This is a regression introduced - I believe - in bug #1940800.

When a portfolio author requests that a comment author make their comment public, the text still says 'This comment is private. The comment author requested that you make their comment public.' even though it should be 'This comment is private. You have requested that this comment be made public.' See number 7 in the screenshot at https://manual.mahara.org/en/21.04/portfolio/feedback.html

To replicate:

1. Create a page as Learner, allow comments, and share the page with a Educator. Leave moderation on 'No'.
2. Educator logs in and leaves a private comment on the page.
3. Learner logs in and views the comment and clicks 'Make comment public'. The Learner sees 'You have requested that this comment be made public.'
4. The Educator logs in and views the page

Expected result: The text below the comment now reads 'This comment is private. The portfolio owner requested that you make your comment public.'

Actual result: Instead, it reads 'This comment is private. The comment author requested that you make their comment public.' which suggests that the comment author (Educator) asked to have the comment made public when it was actually the portfolio author (Learner).

Doris Tam (doristam)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12297

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers