Releasing a current submission produces warning

Bug #1949333 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 22.04
20.10
High
Unassigned
21.04
High
Unassigned
21.10
High
Unassigned
22.04
High
Gold

Bug Description

When I submitted a portfolio via LTI to Brightspace and then release the submission via the admin interface at Admin menu -> Groups -> Current submissions, I get the following warning. There is no warning when the portfolio is submitted via a Mahara group.

[WAR] a3 (lib/mahara.php:1557) sprintf(): Too few arguments
Call stack (most recent first):

    log_message("sprintf(): Too few arguments", 8, true, true, "/var/www/ws-mahara-testing-mahara/releases/2021102...", 1557) at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/errors.php:515
    error(2, "sprintf(): Too few arguments", "/var/www/ws-mahara-testing-mahara/releases/2021102...", 1557, array(size 3)) at Unknown:0
    sprintf("Your portfolio "%s" has been released from "%s" by...", "Internship") at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/mahara.php:1557
    format_langstring("Your portfolio "%s" has been released from "%s" by...", array(size 1), "en.utf8") at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/mahara.php:558
    get_string_location("portfolioreleasedmessage", "group", array(size 1), "format_langstring", "en.utf8") at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/mahara.php:361
    get_string_from_language("en.utf8", "portfolioreleasedmessage", "group", "Internship") at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/view.php:1789
    View->release(object(LiveUser), array(size 1)) at /var/www/ws-mahara-testing-mahara/releases/20211027023906/admin/groups/archives.php:93

To replicate:

1. Set up a deep link assignment in Brightspace (Kristina can help with that)
2. Submit a portfolio as a student.
3. Log into Mahara as site admin.
4. Go to Admin menu -> Groups -> Current submissions.
5. Release the student's portfolio.

Expected result: The portfolio is released without warning.
Actual result: The above warning is thrown but the portfolio still seems to be released.

tags: added: lti-advantage
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12214

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12214
Committed: https://git.mahara.org/mahara/mahara/commit/d5141000cffad46dfcbf0f2fba929d8c6f137f2f
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit d5141000cffad46dfcbf0f2fba929d8c6f137f2f
Author: Gold <email address hidden>
Date: Tue Nov 2 09:54:41 2021 +1300

Bug 1949333: Warning when released from submitted host

Tracked to the incorrect string key. Used the message (which takes more
parameters) rather than the subject.

Tracking this took me though $collection->submittedto(). Resolved a
minor warning that would happen there as well.

Change-Id: I25dec04c025dc6cc4c621f6f9cc7d8f0871f33f9

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12224

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12225

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12226

Revision history for this message
Robert Lyon (robertl-9) wrote :

The fixes for the 21.04 and 20.10 branches are only a subset of the patch committed to main and 21.10

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12225
Committed: https://git.mahara.org/mahara/mahara/commit/70cde7d8301bc8fdb62a4b3e4ef7035f9fc8eecb
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 70cde7d8301bc8fdb62a4b3e4ef7035f9fc8eecb
Author: Robert Lyon <email address hidden>
Date: Thu Nov 4 09:46:29 2021 +1300

Bug 1949333: Warning when released from submitted host

Resolved a minor warning in $collection->submittedto().

Change-Id: Ie5ff0cd979dde8d4443ee406e317ddda493d32b3
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12224
Committed: https://git.mahara.org/mahara/mahara/commit/2c7388dd2907ac1861088531eed8388c0bbdf257
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 2c7388dd2907ac1861088531eed8388c0bbdf257
Author: Gold <email address hidden>
Date: Tue Nov 2 09:54:41 2021 +1300

Bug 1949333: Warning when released from submitted host

Tracked to the incorrect string key. Used the message (which takes more
parameters) rather than the subject.

Tracking this took me though $collection->submittedto(). Resolved a
minor warning that would happen there as well.

Change-Id: I25dec04c025dc6cc4c621f6f9cc7d8f0871f33f9
(cherry picked from commit d5141000cffad46dfcbf0f2fba929d8c6f137f2f)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12226
Committed: https://git.mahara.org/mahara/mahara/commit/99c84f22f9af19aa79965a292ba1d0d8a9d30be2
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_DEV

commit 99c84f22f9af19aa79965a292ba1d0d8a9d30be2
Author: Robert Lyon <email address hidden>
Date: Thu Nov 4 09:46:29 2021 +1300

Bug 1949333: Warning when released from submitted host

Resolved a minor warning in $collection->submittedto().

Change-Id: Ie5ff0cd979dde8d4443ee406e317ddda493d32b3
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers