Activity log for bug #1947528

Date Who What changed Old value New value Message
2021-10-17 23:24:53 Kristina Hoeppner bug added bug
2021-10-18 00:36:59 Kristina Hoeppner mahara: importance High Wishlist
2021-10-18 00:37:10 Kristina Hoeppner description When you set up an external app, e.g. LTI or LTI Advantage, you can delete it from Admin menu -> Web services -> External apps even when some people are still associated with it as authentication method, essentially rendering their accounts unusable. Normally, when an authentication method is still in use, you cannot remove it for an institution. There are a few things that would require clean-up and improvement: 1. Since not all external apps need to be tied to authentication, it would be best to add a new option into the configuration screen of an external app called 'Use for authentication' and add a Yes/No switch so that if an account holder is using it as auth method (primary or secondary), this information can be checked and it can be determined whether to delete that external app or not. 2. If a person still uses that authentication method then the external app should not display a 'Delete' button for that external app so that it can't be deleted accidentally. 3. Actually tie an external app to a particular 'webservice' authentication. Right now, when you select 'webservice' as authentication method in an institution, you can't configure it, and it checks whether web services are available in the institution and then allow those in. It does not check though if, for example, it should be LTI or LTI Advantage with which an account is set up. Therefore, what should happen is the following: a) Site admin sets up an LTI external app for institution A and calls it 'LMS' and sets up a second one for LTI advantage called 'University'. b) Site admin selects 'webservices' (rename to 'External app) as auth method in the institution settings for institution A and sees a drop-down menu with all available external apps, in this case 'LMS' and 'University' and selects one of them. The display in the settings page reads 'External app: LMS' (or 'External app: University'). c) When a student logs in via the LMS external app, their account is associated with that external authentication method. d) On the 'External apps' page, 'LMS' doesn't have a 'Delete' icon because an account is associated with it and uses that app to log in. We will need to think about how to deal with that in an upgrade because at the moment, an institution could have two LTI external apps configured and in the auth instance table there would be only one 'webservices' option, not differentiating between the different apps. When you set up an external app, e.g. LTI or LTI Advantage, you can delete it from Admin menu -> Web services -> External apps even when some people are still associated with it as authentication method, essentially rendering their accounts unusable. Normally, when an authentication method is still in use, you cannot remove it for an institution. There are a few things that would require clean-up and improvement: 1. Bug #1947533 should be fixed first. 2. If a person still uses that authentication method then the external app should not display a 'Delete' button for that external app so that it can't be deleted accidentally. 3. Actually tie an external app to a particular 'webservice' authentication. Right now, when you select 'webservice' as authentication method in an institution, you can't configure it, and it checks whether web services are available in the institution and then allow those in. It does not check though if, for example, it should be LTI or LTI Advantage with which an account is set up. Therefore, what should happen is the following: a) Site admin sets up an LTI external app for institution A and calls it 'LMS' and sets up a second one for LTI advantage called 'University'. b) Site admin selects 'webservices' (rename to 'External app) as auth method in the institution settings for institution A and sees a drop-down menu with all available external apps, in this case 'LMS' and 'University' and selects one of them. The display in the settings page reads 'External app: LMS' (or 'External app: University'). c) When a student logs in via the LMS external app, their account is associated with that external authentication method. d) On the 'External apps' page, 'LMS' doesn't have a 'Delete' icon because an account is associated with it and uses that app to log in. We will need to think about how to deal with that in an upgrade because at the moment, an institution could have two LTI external apps configured and in the auth instance table there would be only one 'webservices' option, not differentiating between the different apps.
2022-01-16 21:21:44 Dianne Tennent mahara: assignee Dianne Tennent (dianne-t)
2022-01-16 21:21:49 Dianne Tennent mahara: status Confirmed In Progress
2022-03-22 05:21:36 Doris Tam mahara: milestone 22.04.0 22.10.0
2022-07-27 21:10:22 Robert Lyon mahara: status In Progress Fix Committed
2022-08-09 22:23:49 Kristina Hoeppner tags newfeature
2022-11-01 00:50:26 Robert Lyon mahara: status Fix Committed Fix Released
2023-01-14 21:51:39 Kristina Hoeppner summary You can delete external apps even when some people are using it as auth method Don't delete external apps even when people are using it as auth method