PDFs in PDF artifacts are not exporting to HTML

Bug #1946046 reported by Gold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned

Bug Description

This looks to be a regression of the following:

https://bugs.launchpad.net/mahara/+bug/1698699

When testing PDF exports to HTML I found the PDF in the artifact block was not being linked to a local file when viewing file:///path/to/extracted/index.html

The block and iframe are present and the iframe is pointing to the the artefact on the site that generated the export.

The iframe is, correctly, showing a '[site] refused to connect' error.

Testing:
Create a Page. Add a PDF block, upload a PDF, save the block.

Export the Page.

Extract the zip and open the index.html file in the HTML directory.

Expected outcome: The PDF is presented in the block in the browser.
Actual outcome: The link points to the site the archive is from and the browser blocks it.

Tags: regression
Revision history for this message
Gold (gold.catalyst) wrote :
Gold (gold.catalyst)
description: updated
Revision history for this message
Robert Lyon (robertl-9) wrote :

This problem came in on commit 5ee26af6fe925599c42612a4bd1146a755215ed0 according to git bisect

Which is the Bug 1915994: Upgrade PDF.js v2.8.335

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/12062

Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → High
status: New → In Progress
Revision history for this message
Dianne Tennent (dianne-t) wrote :

Same problem came through in:
master
MySQL 8
Firefox
Maroon theme
PHP 7.4

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12073

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12073
Committed: https://git.mahara.org/mahara/mahara/commit/9a0ca5243438a00c940b497c6fd677409862e832
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 9a0ca5243438a00c940b497c6fd677409862e832
Author: Robert Lyon <email address hidden>
Date: Thu Oct 7 15:28:09 2021 +1300

Bug 1946046: Exporting PDF block correctly

Fixing the problem with exporting PDF block after the upgrade to
PDF.js v2.8.335

Change-Id: I0750f94e54bd68f6c2042ff4a2fa2239e8ddf9b6
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12140

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12140
Committed: https://git.mahara.org/mahara/mahara/commit/0dddd74dd6bcef3b327d40e50d88fdfd2bc06b10
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 0dddd74dd6bcef3b327d40e50d88fdfd2bc06b10
Author: Robert Lyon <email address hidden>
Date: Thu Oct 7 15:28:09 2021 +1300

Bug 1946046: Exporting PDF block correctly

Fixing the problem with exporting PDF block after the upgrade to
PDF.js v2.8.335

Change-Id: I0750f94e54bd68f6c2042ff4a2fa2239e8ddf9b6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9a0ca5243438a00c940b497c6fd677409862e832)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 21.10rc2 → 21.10.0
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.