Activity log for bug #1943772
| Date | Who | What changed | Old value | New value | Message |
|---|---|---|---|---|---|
| 2021-09-16 00:54:18 | Robert Lyon | bug | added bug | ||
| 2021-09-16 00:55:31 | Robert Lyon | description | There is a problem in module_lti_launch.php when using SAML as parent auth If a person does not exist they are created via create_user() function and this function will check if the auth method they are created with needs a remote username and if so adds a row to the "auth_remote_user" table too. Then module_lti_launch.php creates a row in "auth_remote_user" table for the parent auth (SAML) if the auth method has a parent auth. So we end up with 2 rows But the problem is when we have a parent auth (SAML) as the parent we pass in the parent authinstance id to be the one saved in "usr" table. So we end up with both the rows being connected to the parent auth because we pass in the parent authinstance id when creating the person. When we then login again via LTI it finds the person by email and updates the "auth_remote_user" table but this time adds the row correctly with the LTI authinstance id. So we end up with 3 rows - but we should only have two. | There is a problem in module_lti_launch.php when using SAML as parent auth If a person does not exist they are created via create_user() function and this function will check if the auth method they are created with needs a remote username and if so adds a row to the "auth_remote_user" table too. Then module_lti_launch.php creates a row in "auth_remote_user" table for the parent auth (SAML) if the auth method has a parent auth. So we end up with 2 rows But the problem is when we have a parent auth (SAML) as the parent we pass in the parent authinstance id to be the one saved in "usr" table. So we end up with both the rows being connected to the parent auth because we pass in the parent authinstance id when creating the person. When we then login again via LTI it finds the person by email and updates the "auth_remote_user" table but this time adds the row correctly with the LTI authinstance id. So we end up with 3 rows - but we should only have two. what we should do is if the LTI auth instance has a parent auth and that parent auth allows adding to remote table add that one first, via create_user(), then add the one for LTI | |
| 2021-09-16 00:55:40 | Robert Lyon | mahara: milestone | 21.10.0 | ||
| 2021-09-16 00:55:44 | Robert Lyon | mahara: assignee | Robert Lyon (robertl-9) | ||
| 2021-09-16 00:55:47 | Robert Lyon | mahara: importance | Undecided | High | |
| 2021-09-16 00:55:56 | Robert Lyon | mahara: status | New | In Progress | |
| 2021-09-16 01:44:47 | Kristina Hoeppner | nominated for series | mahara/20.10 | ||
| 2021-09-16 01:44:47 | Kristina Hoeppner | bug task added | mahara/20.10 | ||
| 2021-09-16 01:44:47 | Kristina Hoeppner | nominated for series | mahara/21.04 | ||
| 2021-09-16 01:44:47 | Kristina Hoeppner | bug task added | mahara/21.04 | ||
| 2021-09-16 01:44:47 | Kristina Hoeppner | nominated for series | mahara/21.10 | ||
| 2021-09-16 01:44:47 | Kristina Hoeppner | bug task added | mahara/21.10 | ||
| 2021-09-16 01:44:57 | Kristina Hoeppner | mahara/21.04: status | New | Confirmed | |
| 2021-09-16 01:44:59 | Kristina Hoeppner | mahara/20.10: status | New | Confirmed | |
| 2021-09-16 01:45:01 | Kristina Hoeppner | mahara/21.04: importance | Undecided | High | |
| 2021-09-16 01:45:03 | Kristina Hoeppner | mahara/20.10: importance | Undecided | High | |
| 2021-09-16 01:45:06 | Kristina Hoeppner | mahara/21.04: milestone | 21.04.2 | ||
| 2021-09-16 01:45:13 | Kristina Hoeppner | mahara/20.10: milestone | 20.10.3 | ||
| 2021-09-21 05:29:19 | Doris Tam | mahara/21.04: assignee | Robert Lyon (robertl-9) | ||
| 2021-09-21 05:29:25 | Doris Tam | mahara/21.04: status | Confirmed | In Progress | |
| 2021-10-27 22:10:46 | Kristina Hoeppner | mahara/21.10: milestone | 21.10.0 | 21.10.1 | |
| 2021-10-27 22:11:56 | Kristina Hoeppner | nominated for series | mahara/22.04 | ||
| 2021-10-27 22:11:56 | Kristina Hoeppner | bug task added | mahara/22.04 | ||
| 2021-10-27 22:12:07 | Kristina Hoeppner | mahara/21.04: status | In Progress | Confirmed | |
| 2021-10-27 22:12:10 | Kristina Hoeppner | mahara/21.10: status | In Progress | Confirmed | |
| 2021-10-27 22:12:13 | Kristina Hoeppner | mahara/22.04: status | New | In Progress | |
| 2021-10-27 22:12:16 | Kristina Hoeppner | mahara/22.04: importance | Undecided | High | |
| 2021-10-27 22:12:19 | Kristina Hoeppner | mahara/22.04: milestone | 22.04.0 | ||
| 2021-10-28 20:56:32 | Gold | mahara/21.04: milestone | 21.04.2 | 21.04.3 | |
| 2021-10-28 21:37:47 | Dianne Tennent | mahara/20.10: milestone | 20.10.3 | 20.10.4 | |
| 2022-01-16 20:49:33 | Robert Lyon | mahara/22.04: status | In Progress | Fix Committed | |
| 2022-01-17 03:04:39 | Robert Lyon | mahara/21.10: status | Confirmed | Fix Committed | |
| 2022-01-17 03:04:41 | Robert Lyon | mahara/21.04: status | Confirmed | Fix Committed | |
| 2022-01-17 03:04:48 | Robert Lyon | mahara/20.10: status | Confirmed | Fix Committed | |
| 2022-02-01 02:40:09 | Doris Tam | mahara/21.10: assignee | Robert Lyon (robertl-9) | ||
| 2022-02-01 02:40:12 | Doris Tam | mahara/21.04: assignee | Robert Lyon (robertl-9) | ||
| 2022-02-09 03:41:26 | Dianne Tennent | mahara/21.10: status | Fix Committed | Fix Released | |
| 2022-02-09 03:42:21 | Gold | mahara/20.10: status | Fix Committed | Fix Released | |
| 2022-02-09 04:15:30 | Doris Tam | mahara/21.04: status | Fix Committed | Fix Released | |
| 2022-03-21 04:01:14 | Doris Tam | mahara/22.04: assignee | Robert Lyon (robertl-9) | ||
| 2022-04-27 01:50:44 | Gold | mahara/22.04: status | Fix Committed | Fix Released |
