Adding annotation doesn't alert if you change page without saving - leaves empty block on the page

[Robert Lyon]

After clicking the dot on the smart evidence page to display the annotation modal you decide to reload the page before saving the form or exiting out with the 'X' button the empty annotation block still exists on the corresponding page.

When you do this multiple times from the smart evidence page, multiple annotations with the same evaluation item are created on the corresponding page.

There needs to be form change checker alert if we are adding the block (but not when editing) to alert one when leaving the page. And on leaving to clean up the half finished block.

[Dianne Tennent (dianne-t)]

Steps to reproduce:
- Learner makes a copy of SmartEvidence template made available by their institution
- Learner creates a page and adds this to the template collection
- Admin to ensure the blocktype/annotation plugin is enabled
- Reviewer or learner makes annotation on matrix page for one of the criteria
- Reload page before saving or pressing the X on the annotation modal
- Check newly added page

Expected result - no annotations appear on this page

Actual result - Annotation heading appears on this page

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/12044

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12124

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12175

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12124
Committed: https://git.mahara.org/mahara/mahara/commit/69306ce352c131f79c7bb54ccc9dd504da8cd883
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 69306ce352c131f79c7bb54ccc9dd504da8cd883
Author: Dianne Tennent <email address hidden>
Date: Wed Sep 29 16:56:19 2021 +1300

Bug 1929357: Do not create block when leaving annotation

If people close the annotation edit window or leave
without saving, no block will be created.

Change-Id: Ic37c42bc628fa5fb8f027efa975f321ba6ca6e99

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12585

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12585
Committed: https://git.mahara.org/mahara/mahara/commit/707bba07b1ca1290e6d1ba0ad53549d853333a26
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 707bba07b1ca1290e6d1ba0ad53549d853333a26
Author: Robert Lyon <email address hidden>
Date: Thu Apr 7 14:43:13 2022 +1200

Bug 1929357 - adding back in the hide dock

So that when others are giving feedback the dock closes

Change-Id: I71c9f36784ad6b42cf0fd2bcf6fc3e1c212953e3
Signed-off-by: Robert Lyon <email address hidden>