Upgrade Bootstrap from 4.3.1 to 5.0.1 (LTS ends in Nov 2022)

[Doris Tam]

https://github.com/twbs/bootstrap/releases

4.5.0
- Updated to jQuery v3.5.1, Jekyll v4, and dropped Node.js < 10 for development
- Deprecated bg-gradient-variant mixin as it's being removed in v5.

4.4.0
- "Deprecated: bg-variant(), nav-divider(), and form-control-focus() mixins are now deprecated as they're going away in v5."

We should update to 4.6.0.

https://endoflife.date/bootstrap LTS for BS4 ends in November this year.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11592

[Doris Tam (doristam)]

scss bug that needs to look futher into

---
Error in plugin "sass"
Message:
htdocs/theme/raw/sass/lib/bootstrap4/_grid.scss
Error: Undefined operation: "null gt 0".
on line 29 of htdocs/theme/raw/sass/lib/bootstrap4/_grid.scss, in mixin `@content`
from line 62 of htdocs/theme/raw/sass/lib/bootstrap4/mixins/_breakpoints.scss, in mixin `media-breakpoint-up`
from line 23 of htdocs/theme/raw/sass/lib/bootstrap4/_grid.scss
from line 16 of htdocs/theme/raw/sass/lib/bootstrap4/bootstrap.scss
from line 14 of htdocs/theme/raw/sass/style.scss
from line 20 of htdocs/theme/default/sass/style.scss

> @if ($container-max-width > $width or $breakpoint == $name) {
---

-------------^

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11820

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12108

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12109

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12110

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12265

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12267

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12275

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12784

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12786

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12789

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12790

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12793

[Dianne Tennent (dianne-t)]

Testing notes:
 - Elements are visible below 1200px viewport width
 - Positioning of Yes/No switch boxes
 - Page edit toolbar buttons are positioned correctly
 - Layout of forum posts
 - Pages and collections page 'Search' and 'Sort by' fields should be side by side
 - Menu icons are center-aligned horizontally
 - Forums page: <hr> lines match main and Group administrators name displays below list of forums
 - Forum>Topic: 'Choose and actions' and 'Update selected topics' should be side by side, also check <hr> lines
 - Forum post: layout of user info/post, vertical lines to the left of each post should be grey, not black/dark grey, reply button should be aligned to the right
 - Forums - check horizontal lines
 - Resume: add one item to 'Achievements' and view; there should be no <hr> below the item
- 'Add a person' page: 'Create account' button should be full width and centered in panel '3 - Create'
- Check alignment of block option icons/text when adding new block
- Check close button on modals
- Plans>Tasks list striped table grey row correct shade of grey

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12834

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12922

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12966

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12834
Committed: https://git.mahara.org/mahara/mahara/commit/de0dab0fe95b7125b6e577db1528eaa5be79b0b6
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit de0dab0fe95b7125b6e577db1528eaa5be79b0b6
Author: Dianne Tennent <email address hidden>
Date: Thu Jun 2 14:24:49 2022 +1200

Bug 1915975: Update DataTables.js to work with Bootstrap 5

Replace min.js/css files with Bootstrap 5 compatible ones

Change-Id: I3faeb7b98efc1fb211934cabf39aad943a268b9b

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12793
Committed: https://git.mahara.org/mahara/mahara/commit/e3a2b0e73456f87c3e8ea176759dde96bb486bf1
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit e3a2b0e73456f87c3e8ea176759dde96bb486bf1
Author: Dianne Tennent <email address hidden>
Date: Tue May 24 17:04:50 2022 +1200

Bug 1915975: Various Bootstrap 5 fixes (Raw theme)

- Remove .switch padding and obsolete variables
- Override .form-control, .form-text, .form-inline, .input-group
classes to replace deprecated styling
- Update .badge-* color classes to .bg-*, fix .badge styling rules
- Fix .btn-close styling
- Fix forum post left border color, blocktype icons, edit toolbar
buttons
- Fix 'Choose file" button styling on import Leap2a page
- Fix table borders/colors on Plans>Tasks and Forum posts
- Fix width of input fields on 'Edit collection' page
- Fix <hr> styling e.g. on Forum>Topic>Post
- Alignment/reponsive styling on 'Choose an action' and
'Update selected topics' input fields under forum posts
- Reapply headings styling
- 'Add block' modal header height
- 'Edit block' modal header height

Change-Id: Ie26157ad551ef876e86b649f13bf72cbe704f526

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12789
Committed: https://git.mahara.org/mahara/mahara/commit/946e328d2595f599f94d8e08171b6d3679970308
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 946e328d2595f599f94d8e08171b6d3679970308
Author: Dianne Tennent <email address hidden>
Date: Mon May 23 17:03:03 2022 +1200

Bug 1915975: Disable Responsive Font Sizing

Generating the 'enable' class disables rfs by default.

Change-Id: I54ca399eec359c5ec45432902ac82e5b33305144

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12790
Committed: https://git.mahara.org/mahara/mahara/commit/fb2a2296d555a18f9aa50c52be736e5e81447039
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit fb2a2296d555a18f9aa50c52be736e5e81447039
Author: Dianne Tennent <email address hidden>
Date: Tue May 24 11:16:05 2022 +1200

Bug 1915975: Replace .sr-only with .visually-hidden

Change-Id: Ib6b4b411fc9e26937afb9fa311d465332e23c364

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12784
Committed: https://git.mahara.org/mahara/mahara/commit/15854ebffd7dfd37f8209f4abea301881883199a
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 15854ebffd7dfd37f8209f4abea301881883199a
Author: Dianne Tennent <email address hidden>
Date: Tue May 17 16:04:30 2022 +1200

Bug 1915975: Remove .media and replace text-right/left

Remove .media component and replace with Bootstrap 5
flex utilities
Replace text-right/left with text-end/start

Change-Id: Ie46fd785f8a41f2bedca20baa8dcda2b85eb5682

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12786
Committed: https://git.mahara.org/mahara/mahara/commit/b9938f5640185d11f188b48ccba791d3f1947d53
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit b9938f5640185d11f188b48ccba791d3f1947d53
Author: Dianne Tennent <email address hidden>
Date: Wed May 18 15:31:08 2022 +1200

Bug 1915975: replace old Bootstrap classes

- a few float-left/right -> float-start/end
- dropdown-menu-left/right -> start/end
- .close -> btn-close
- updated html-formatter bootstrap.min.css file
- change .ml-* to .ms-*

Change-Id: I8e9f33dd9366eb251e39202d67c36b417b8354ec

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12275
Committed: https://git.mahara.org/mahara/mahara/commit/664586ab0ab629820bf18d7ce8ece8c3f6649281
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 664586ab0ab629820bf18d7ce8ece8c3f6649281
Author: Doris Tam <email address hidden>
Date: Fri Nov 26 10:57:04 2021 +1300

Bug 1915975: Card dropdown try new Bootstrap5 accordion

Change-Id: I3edc85f920aa2c13b573d66b471c712a87a1786a

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12269
Committed: https://git.mahara.org/mahara/mahara/commit/2c705c51e3464e387c606b8816688520b525dec3
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 2c705c51e3464e387c606b8816688520b525dec3
Author: Doris Tam <email address hidden>
Date: Tue Nov 23 14:51:13 2021 +1300

Bug 1915975: Bootstrap 5 - Sass changes part 1

https://getbootstrap.com/docs/5.0/migration/#sass
This patch:
- Rename color-yiq() function and related variables to color-contrast()
- Change media query mixins parameters
- Drop color(), theme-color(), and gray() functions in favor of
variables

Change-Id: I815363d9a5f1640347fe701bc40d5847c98fcd1e

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12263
Committed: https://git.mahara.org/mahara/mahara/commit/5404690569561d4c47b63f5764d89dbe3b9867b9
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 5404690569561d4c47b63f5764d89dbe3b9867b9
Author: Doris Tam <email address hidden>
Date: Mon Nov 22 15:20:43 2021 +1300

Bug 1915975: Bootstrap 5 - data attributes

Update data-toggle to data-bs-toggle and data-target to data-bs-target

Change-Id: I8bd7ca8105a2cd43096e740fd51cce5d8bfaf389

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12110
Committed: https://git.mahara.org/mahara/mahara/commit/7f7ea5e65df578343cf9a8bf23aa23348d2ce0a8
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 7f7ea5e65df578343cf9a8bf23aa23348d2ce0a8
Author: Doris Tam <email address hidden>
Date: Thu Jun 3 10:39:32 2021 +1200

Bug 1915975: Fix up tinymce scss post-upgrade of bootstrap5

Change-Id: I37d03a2b51482cacd3744501f5b10af25b27b86b

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12109
Committed: https://git.mahara.org/mahara/mahara/commit/e70e249f64a9d10109b1fd29ae6e86c24cffe4f8
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit e70e249f64a9d10109b1fd29ae6e86c24cffe4f8
Author: Evonne <email address hidden>
Date: Thu Jun 3 12:57:40 2021 +1200

Bug 1915975: Update the use of float-right/left to float-start/end

behatnotneeded

Change-Id: I4a0ab4506b80b654e0759e1ca2c684dc258a20ea

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12108
Committed: https://git.mahara.org/mahara/mahara/commit/8590747cda81e5ba97a1ac80d847b86518500575
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 8590747cda81e5ba97a1ac80d847b86518500575
Author: Doris Tam <email address hidden>
Date: Tue Jun 1 12:32:43 2021 +1200

Bug 1915975: Upgrade bootstrap4 to bootstrap5

Adding compatibility to the new sass:
-> converting node-sass to dart-sass

- remove old bootstrap4 repo that wasn't used for anything
- `data-...` classes updated to `data-bs-...`
- updated bootstrap min.js files @ htdocs/lib/bootstrap/assets/javascripts
not sure what they are needed for yet
- the date time picker is not related to bootstrap and is a library of its own
and doesn't have a bootstrap5 version yet
Related to Bug 1918357

Change-Id: Ic0e18a648b6318d90e8d0d2f863de388def237da

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12267
Committed: https://git.mahara.org/mahara/mahara/commit/d92e0740869712be0fe5c4f1c0937174ae080e7e
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit d92e0740869712be0fe5c4f1c0937174ae080e7e
Author: Doris Tam <email address hidden>
Date: Tue Nov 23 12:30:43 2021 +1300

Bug 1915975: Remove bootstrap4

- add a sanity check to make sure the compiled css matches the bootstrap version
- added a note in the bootstrap README.Mahara file to update this variable when upgrading

Change-Id: I99146c7feea47adbbce0ff79e3608ff7052a40db

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12922
Committed: https://git.mahara.org/mahara/mahara/commit/732cedf46162b9dd46b73b61c1e869b34c0d7b69
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 732cedf46162b9dd46b73b61c1e869b34c0d7b69
Author: Dianne Tennent <email address hidden>
Date: Mon Jun 20 15:52:25 2022 +1200

Bug 1915975: Bootstrap 5 fixes (Default theme)

- Fix font properties on dashboard page
- Delete button alignment on Settings/Preferences
- Add/Copy buttons on Create page

Change-Id: Ifa6a9cb304444f297ffb65cfce734ac154f7d2b2

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12827
Committed: https://git.mahara.org/mahara/mahara/commit/8129b1aeb574397de2a52342bdd00b89782b2dd1
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 8129b1aeb574397de2a52342bdd00b89782b2dd1
Author: Robert Lyon <email address hidden>
Date: Fri May 27 14:33:30 2022 +1200

Bug 1915975: Test to get behat to pass for BS5

Problem:
- the "I press" and "I follow" steps don't want to work now
so have converted them to "I click on"

Change-Id: I6e3f9ddb2ed3792912a50a1141c915be9c2da3f9
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12966
Committed: https://git.mahara.org/mahara/mahara/commit/d291ff6c125544d22cf65884114883ee5ae8f79a
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit d291ff6c125544d22cf65884114883ee5ae8f79a
Author: Dianne Tennent <email address hidden>
Date: Tue Jul 5 13:56:05 2022 +1200

Bug 1915975: Bootstrap 5 fixes (Maroon theme)

- admin/groups/settings.php: 'Membership' heading font
- admin/users/institutionusers.php: 'People who have requested'
heading font
- mahara/: 'Create' 'Share' 'Engage' font and spacing
- admin/extensions/plugins.php: Plugin type: blocktype settings
cog in card heading aligned with top of card
- module/framework/frameworkmanager.php?id=1: 'Display assessment
statuses' heading font
- theme/styleguide.php: 'Button group top’ example – ‘Context’
alignment within the box
- theme/styleguide: Attachment card - 'Attachments' heading
- data-dismiss -> data-bs-dismiss
- .visually-hidden regression
- Submissions table in module/submissions/index.php
- make datetimepicker compatible with BS5
- responsive column sizing on cookies page
- Smart Evidence heading fonts
- Admin > Webservices > External apps 'Application' input should not be
full width <768px
- 'Edit block' modal: check block title input field same as main <768px
and >1200px
- Share > Submisisons: Quick filter options should NOT be full
width at <768px
- Shared by me: width of search and sort fields <768 and >1440

Change-Id: I24bbc617ee0752cc6c1a5ddecc4d9694ccd3df78

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13125

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13125
Committed: https://git.mahara.org/mahara/mahara/commit/6eb00f9741a805d2d93689110bf8bc92acdd3c37
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 6eb00f9741a805d2d93689110bf8bc92acdd3c37
Author: Evonne <email address hidden>
Date: Mon Aug 22 14:08:02 2022 +1200

Bug 1915975 Design adjustments for bootstrap 5

- Remove underline in dropdown options.
- Fix active state for badges for text to be readable.
- Put in a style for carousel captions.
- Fix the delete post collapsible in forum.
- Fix the active state of the btn primary so it doesn't inherit
text colour instead (might need to revise this one as there
might be a reason for it forgotten).
- Skin thumbnail link outline to full image.
- Correct the vertical alignment of the collapsible indicator in
attachments and card-footer.
- Increased the width of the datepicker to allow font differences.
- Fix card list-group last child background covering the card
bottom border radius.
- Fix the attachment table that visually need to align with the
list-group attachment.
- Fix the help icon z-index in form-group.
- Fix Plan tasks collapse indicator placement.
- Fix header loading icon alignment and responsive header not wrapping.
- Fix modal comment attachment width to full width.
- Fix secret url table bottom border.
- Fix some user-icon links focus not being around full image.
- Fix the submissions table and pagination for responsive.
- Fix fieldset body border top to not be there so no double border
when there is a legend preceeding it, with some exceptions.
- Fix the Fonts page where you click on view font specimen and the
fonts for the whole site shrinks.
- Move messages appearing in card header to card-body for file upload.
- Fix select2 vertical alignment of names with img.
- Fix the padding for filter input.
- Fix the min-height for the left to right field selects so they align.
- Fix labels kissing inputs in tables.
- Fix the Components library collapsible heading and table.
- Fix web services config form layout.
- Fix pageaction dropdown menu items wrapping around icon.
- Fix collections nav dropdown select icon overlapping text.
- Fix alignment of checkboxes with text.
- Fix styleguide.
- Fix dropdown alignment with icon.
- Fix submit form in viewfooter in responsive.
- Fix inconsistent dropdown-menu and add class for when there's icon.
- Fix the mess of button border radius in btn-groups.
- Fix some card-collapses that were double wrapped.
- Fix choose skins collapsible wrappers.
- Fix collapsibles that were inconsistently border-radiused.
- Fix date picker icon in tables.
- Fix some button groups that need to separate when responsive.
- Fix card-header-tabs to look more integrated.
- Fix all the themes.

behatnotneeded

Change-Id: I8641e84f2d51177ccd683a9e84bcbcd7113c8cd4

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13180
Committed: https://git.mahara.org/mahara/mahara/commit/dffce75186aff4337605e36bd8c2f358b8b6461a
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit dffce75186aff4337605e36bd8c2f358b8b6461a
Author: Robert Lyon <email address hidden>
Date: Fri Sep 23 09:40:34 2022 +1200

Bug 1915975: Sass deprecation warning and icon change

On line 51, column 25 of htdocs/theme/raw/sass/components/_modal.scss:
Add a space after - to clarify that it's meant to be a binary operation

Change the 'My groups' icon to reflect the new groups icon

Change-Id: Ia07a745ebb05ad3c5c5f06318d08973b6ce6f103
Signed-off-by: Robert Lyon <email address hidden>