Issues with postgres 12 and adsrc column

[Robert Lyon]

Get this error:

EXECUTE("SELECT d.adnum as num, d.adsrc as def from pg_attrdef d, pg_class c where d.adrelid=c.oid and c.relname='usr_login_data' order by d.adnum")

 Call stack (most recent first):
  * exception(object(ADODB_Exception)) at Unknown:0
 [DBG] d3 (lib/errors.php:692) Exception thrown by smarty call while handling exception:
 [DBG] d3 (lib/errors.php:692) [ADODB_Exception]: postgres8 error: [-1: ERROR: column d.adsrc does not exist
 [DBG] d3 (lib/errors.php:692) LINE 1: SELECT d.adnum as num, d.adsrc as def from pg_attrdef d, pg_...#012PHP message: [DBG] d3 (lib/errors.php:692)

To fix it we need to do the following

https://github.com/ADOdb/ADOdb/issues/562

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11534

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11534
Committed: https://git.mahara.org/mahara/mahara/commit/04ff5a71c2e288ee912f50de1c1963fe3deba66e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 04ff5a71c2e288ee912f50de1c1963fe3deba66e
Author: Robert Lyon <email address hidden>
Date: Thu Jan 28 15:37:14 2021 +1300

Bug 1913504: Updating an obsolete SQL check

Fails in postgres 12

And as vast majority of sites should be using postgres > 7 this change
shouldn't break anything as the SQL change is the same SQL in the
htdocs/lib/adodb/drivers/adodb-postgres8.inc.php file

Change-Id: Ia343acec57af31a3c1097a861a5078c4ad866aa6
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11685

[Mahara Bot (dev-mahara)]

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11686

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11687

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11744

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11685
Committed: https://git.mahara.org/mahara/mahara/commit/1c72015ad7e7c737cb33fe7d4622b8a41859b1c9
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 1c72015ad7e7c737cb33fe7d4622b8a41859b1c9
Author: Robert Lyon <email address hidden>
Date: Thu Jan 28 15:37:14 2021 +1300

Bug 1913504: Updating an obsolete SQL check

Fails in postgres 12

And as vast majority of sites should be using postgres > 7 this change
shouldn't break anything as the SQL change is the same SQL in the
htdocs/lib/adodb/drivers/adodb-postgres8.inc.php file

Change-Id: Ia343acec57af31a3c1097a861a5078c4ad866aa6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 04ff5a71c2e288ee912f50de1c1963fe3deba66e)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11686
Committed: https://git.mahara.org/mahara/mahara/commit/4de79791ed40fbb94a37928a8352e06d0d9207c7
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 4de79791ed40fbb94a37928a8352e06d0d9207c7
Author: Robert Lyon <email address hidden>
Date: Thu Jan 28 15:37:14 2021 +1300

Bug 1913504: Updating an obsolete SQL check

Fails in postgres 12

And as vast majority of sites should be using postgres > 7 this change
shouldn't break anything as the SQL change is the same SQL in the
htdocs/lib/adodb/drivers/adodb-postgres8.inc.php file

Change-Id: Ia343acec57af31a3c1097a861a5078c4ad866aa6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 04ff5a71c2e288ee912f50de1c1963fe3deba66e)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11687
Committed: https://git.mahara.org/mahara/mahara/commit/ee95f670a8b920c63336fbe87b4bc5be9af7c8fd
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit ee95f670a8b920c63336fbe87b4bc5be9af7c8fd
Author: Robert Lyon <email address hidden>
Date: Thu Jan 28 15:37:14 2021 +1300

Bug 1913504: Updating an obsolete SQL check

Fails in postgres 12

And as vast majority of sites should be using postgres > 7 this change
shouldn't break anything as the SQL change is the same SQL in the
htdocs/lib/adodb/drivers/adodb-postgres8.inc.php file

Change-Id: Ia343acec57af31a3c1097a861a5078c4ad866aa6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 04ff5a71c2e288ee912f50de1c1963fe3deba66e)