Mahara

Access list needs to retain the sorted list of people

  1. Series 20.10
  2. Bug #1903620
Bug #1903620 reported by Lisa Seeto
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
20.04
Fix Released
High
Unassigned
Mahara 20.04.3
20.10
Fix Released
High
Unassigned
Mahara 20.10.1
21.04
Fix Released
High
Lisa Seeto
Mahara 21.04.0

Bug Description

There needs to be a code fix in access.json.php on line 71:

array_keys($peoplein);

should be:

$peoplein = array_keys($peoplein);

Tags: code-cleanup
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11428

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11428
Committed: https://git.mahara.org/mahara/mahara/commit/69824469fcd746a3fa43958271018055a1020446
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 69824469fcd746a3fa43958271018055a1020446
Author: Lisa Seeto <email address hidden>
Date: Tue Nov 10 14:55:42 2020 +1300

Bug 1903620: access list needs retain the sorted list of people

- retain the sorted list in the $peoplein var

Change-Id: I14b8a40b6b3d4c6bdd33f3bf1495a427634535a4
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11442

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11443

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11443
Committed: https://git.mahara.org/mahara/mahara/commit/852de9b0398f67b8a70911cb4c0b8f53a7bc8f04
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 852de9b0398f67b8a70911cb4c0b8f53a7bc8f04
Author: Lisa Seeto <email address hidden>
Date: Tue Nov 10 14:55:42 2020 +1300

Bug 1903620: access list needs retain the sorted list of people

- retain the sorted list in the $peoplein var

Change-Id: I14b8a40b6b3d4c6bdd33f3bf1495a427634535a4
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 69824469fcd746a3fa43958271018055a1020446)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11442
Committed: https://git.mahara.org/mahara/mahara/commit/9477bbde4a1f4b4b5f4b58a09491cb86063061df
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 9477bbde4a1f4b4b5f4b58a09491cb86063061df
Author: Lisa Seeto <email address hidden>
Date: Tue Nov 10 14:55:42 2020 +1300

Bug 1903620: access list needs retain the sorted list of people

- retain the sorted list in the $peoplein var

Change-Id: I14b8a40b6b3d4c6bdd33f3bf1495a427634535a4
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 69824469fcd746a3fa43958271018055a1020446)

Kristina Hoeppner (kris-hoeppner)
summary: - access list needs retain the sorted list of people
+ Access list needs to retain the sorted list of people
Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.