Wrong error message for not being able to log in when institution is suspended

[Kristina Hoeppner]

When an institution is suspended, and an institution member tries to log in, the error message is still the same login error message for when the wrong information is entered into the form (see attachment). As there is no form on the page that is displayed to the person trying to log in, it can cause confusion until they read the non-error text.

It would be better to have a different error message and say 'There was an error submitting this form. Your institution has been suspended.'

And keep the more detailed explanation under 'Access denied'.

To replicate:

1. Set up an institution and add one person, Person A (not the site admin).
2. Suspend the institution.
3. Log in as Person A.
Expected result: See the 'Access denied' page with a relevant error message in red.
Actual result: Misleading error message.

[Robert Lyon (robertl-9)]

Attached an example of the text when trying to login to an institution that is currently suspended

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11385

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11385
Committed: https://git.mahara.org/mahara/mahara/commit/8fef3553026502131f6b8374579266d17f537fe9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8fef3553026502131f6b8374579266d17f537fe9
Author: Robert Lyon <email address hidden>
Date: Mon Oct 19 14:16:06 2020 +1300

Bug 1897484: Showing a different generic message when failing to login

As the normal one relates to form fields and that is not always correct

Change-Id: Id4f061a082366deaf3aa5caafd0058b622af25e4
Signed-off-by: Robert Lyon <email address hidden>