Allow CSV, ZIP, and MATRIX files on certain screens when file extension restrictions are in place

Bug #1896683 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Unassigned

Bug Description

When the config variable '$cfg->validfiletypes' is set, only the file types mentioned can be uploaded to Mahara. That impacts a number of admin screens where we need to be able to upload CSV and MATRIX files in particular:

- Add people by CSV
- Create groups by CSV
- Add group members by CSV
- Import SmartEvidence framework file
- Upload Leap2A file to create an account (and same for importing Leap2A into an existing account).

It would not necessarily be good to have to allow these file types in general. Therefore, it would be good to always allow them on the screens where they are needed to fulfil basic operations in Mahara.

Tags: newfeature
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11387

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12114

Changed in mahara:
milestone: none → 22.04.0
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12114
Committed: https://git.mahara.org/mahara/mahara/commit/1ad45d2da804480c4b780effcf3f405db938f04c
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 1ad45d2da804480c4b780effcf3f405db938f04c
Author: Robert Lyon <email address hidden>
Date: Mon Oct 19 17:13:26 2020 +1300

Bug 1896683: Doing checks on special upload places

Problems
1) matrix files are not able to be uploaded if '$cfg->validfiletypes'
is on and '.matrix' is not specified but should not need to be
specified as it is an admin section thing

2) csv uploads don't go thru uploadmanager are so not actually checked
if they are valid csv files

Change-Id: I91c3c2da6edd2a2f34d62d621c374abf86166971
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12270

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12270
Committed: https://git.mahara.org/mahara/mahara/commit/da60bd00ca372e45816ff303aac3ae7acf685294
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit da60bd00ca372e45816ff303aac3ae7acf685294
Author: Robert Lyon <email address hidden>
Date: Wed Nov 24 12:25:18 2021 +1300

Bug 1896683: Doing checks on leap2a import page

Change-Id: Ifc038487bcebdd655ee1f4687664965b964a7228
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: newfeature
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.