Only SAML auth instance for metadata not active but can still see metadata choice on IdP discovery page

Bug #1892254 reported by Robert Lyon on 2020-08-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Robert Lyon

Bug Description

If we have the following:

A site with a couple of institutions (Institution1 and Institution2) each having a SAML auth instance with different metadata (say IdP1 and IdP2)

If Instance2 sets it's saml auth to not be active then we shouldn't expect to see the auth option on the IdP Discovery page ( auth/saml/index.php )

We need to adjust the discovery page to only show the IdP's that are being used by 1 or more active SAML instances.

Robert Lyon (robertl-9) on 2020-08-19
Changed in mahara:
importance: High → Wishlist
milestone: none → 20.10.0
Robert Lyon (robertl-9) on 2020-08-19
Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/11158
Committed: https://git.mahara.org/mahara/mahara/commit/599740ae944fe305081136b39d251c7e634c683d
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 599740ae944fe305081136b39d251c7e634c683d
Author: Robert Lyon <email address hidden>
Date: Thu Aug 20 09:20:14 2020 +1200

Bug 1892254: Only show active instance IdPs on discovery page

If we have more metadata options than we need - we should not show the
extra ones

Change-Id: I506c1ebfd9764a66dffb0b5128ee680ffbe82046
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
assignee: nobody → Robert Lyon (robertl-9)
tags: added: nominatedfeature
tags: added: newfeature
removed: nominatedfeature
Robert Lyon (robertl-9) on 2020-10-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers