Allow webservices external apps to show configuration options based on functions it contains

Bug #1892106 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Robert Lyon

Bug Description

Currently the LTI module has the ability to configure the following 2 options:
- autocreateusers
- parentauth

And they are used in the module_lti_launch function.

But if we make a custom webservice and include module_lti_launch as one of it's services we have no way (apart from directly on database) to set these options

Currently the webservice/admin/oauthv1sregister.php page shows the config cog if a module has
has_oauth_service_config() set to true and displays the config form via get_oauth_service_config_options()

But what we should have is some code that checks if the webservice contains functions that have config options and then display the button / form

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11157

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → Wishlist
milestone: none → 20.10.0
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11157
Committed: https://git.mahara.org/mahara/mahara/commit/bcdebe61933dcb3d6bece59f6c433961db594400
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit bcdebe61933dcb3d6bece59f6c433961db594400
Author: Robert Lyon <email address hidden>
Date: Wed Aug 19 12:07:22 2020 +1200

Bug 1892106: Adding hasconfig value to external_functions table

So that functions can alert if they have special config

And check for the service functions that have special config

Change-Id: Ic2bc5ddc1e39f403d1b2583f6d18ec99919d3ffa
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
tags: added: newfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.