Mahara

skins: need to remove background/header image if artefact is not there anymore

Bug #1890364 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic
Mahara 20.10.0

Bug Description

When saving a skin in function commit() there need to be extra checks to see if the artefact still exists on the DB, since it can be removed from the site when it's still linked to a skin, and also check if the file is present on dataroot

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

https://reviews.mahara.org/#/c/11112/

Lisa Seeto (lisaseeto)
Changed in mahara:
status: New → In Progress
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
milestone: none → 20.10.0
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11112
Committed: https://git.mahara.org/mahara/mahara/commit/89157c16a2cb844fb6842ca1ad97aefcf36ccbb1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 89157c16a2cb844fb6842ca1ad97aefcf36ccbb1
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Aug 5 11:52:07 2020 +1200

Bug 1890364: remove sking background images if not artefact exists

behatnotneeded

Change-Id: Idaf9167a95d08a8aaf25cf219a1b678454c942d2

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.