Upgrade: ADODB 5.20.16 to 5.20.18

[Lisa Seeto]

Related to https://bugs.launchpad.net/mahara/+bug/1865115

Our current version of ADODB (5.20.16) can be upgraded to version 5.20.18.

https://github.com/ADOdb/ADOdb/releases

Change logs:
-------------
5.20.18 - 28-Jun-2020:
 mssql: Retrieve error messages early before connection closed. #614

5.20.17 - 31-Mar-2020:
  core: fix PHP notice in ADOdb_Exception constructor when using transactions. #601
  mssql: fix PHP notice due to uninitialized array with PHP 7.4. #608
  active record: Fix UpdateActiveTable failing with mixed case column names. #610

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11222

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11224

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11225

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11226

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11228

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11229

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11230

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11231

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11234

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11235

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11235
Committed: https://git.mahara.org/mahara/mahara/commit/fa36e4ea10bd6a5d9f04bcd682ca679d27fd0dbd
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit fa36e4ea10bd6a5d9f04bcd682ca679d27fd0dbd
Author: Robert Lyon <email address hidden>
Date: Mon Aug 10 12:39:36 2015 +1200

Bug 1890213: escaping names

>From this change: https://reviews.mahara.org/#/c/5072/

behatnotneeded

Change-Id: Ice7932322522cd301a76468bd03ee0615070ab1f
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11231
Committed: https://git.mahara.org/mahara/mahara/commit/982b87a2dc83ba39fc2f87f06c508e7c7547432e
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 982b87a2dc83ba39fc2f87f06c508e7c7547432e
Author: Son Nguyen <email address hidden>
Date: Thu Sep 1 08:38:35 2016 +1200

Bug 1890213: determine if array is associative

Bug 1619036: Fix a bug when determine if an array is associative

Use the original code from ADODB 5.20.5

behatnotneeded

Change-Id: Iffbdda6dd150cfe6c7fe428b1fa4661563faa9bb

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11230
Committed: https://git.mahara.org/mahara/mahara/commit/83a67bf5f276a5a86a59be42c5426f07a5bb8651
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 83a67bf5f276a5a86a59be42c5426f07a5bb8651
Author: Robert Lyon <email address hidden>
Date: Fri Jan 29 15:25:19 2016 +1300

Bug 1890213: Moving the define ADODB_ASSOC_CASE_* calls

Bug 1539346: Moving the define ADODB_ASSOC_CASE_* calls

As they are needed by ADONewConnection even when ADODB_EXTENSION is
above 4.0

behatnotneeded

Change-Id: Ie9bc965bc6aac6fbf2a94b58d647af8d83b5cf59
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11228
Committed: https://git.mahara.org/mahara/mahara/commit/75100cb7ef9959d40adc9abca93be88385ed9de2
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 75100cb7ef9959d40adc9abca93be88385ed9de2
Author: Richard Mansfield <email address hidden>
Date: Mon Jun 13 15:30:35 2011 +1200

Bug 1890213: check for valid columns in driver

Check for valid columns in adodb postgres64 driver MetaIndexes fn (bug #796102)

Indexes on functions of columns have a 0 in the indkey column of
pg_catalog.pg_index, which doesn't refer to a column.

Don't return any columns for the index, rather than returning an empty
column name.

Change-Id: I531e75bacf8c845beadc7d8286eb28ef5281d923
Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11229
Committed: https://git.mahara.org/mahara/mahara/commit/bb195dcb1610f6bdc1f1479672b54db9140332c6
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit bb195dcb1610f6bdc1f1479672b54db9140332c6
Author: Robert Lyon <email address hidden>
Date: Mon Aug 15 12:27:03 2016 +1200

Bug 1890213: modify session variable

Modified session variable setting in ADOdb adodb-pager.inc.php

Bug 1539346

Was originally part of commit 55a8deb8cbd2e1455c7af3a35c50b7cad76d63df
but have moved it out to own patch for purposes of adodb version update

Change-Id: I1dd5017432999a9e5256fb17dcbd028c60931367
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11226
Committed: https://git.mahara.org/mahara/mahara/commit/07a7e5f91bf175e0ed6cb05e3e2f648e16b34f73
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 07a7e5f91bf175e0ed6cb05e3e2f648e16b34f73
Author: Francois Marier <email address hidden>
Date: Mon May 17 17:47:01 2010 +1200

Bug 1890213: check for postgres 8.1

adodb: check for Postgres 8.1

See Eduforge #2318 or LP #547951.

(cherry picked from commit 4bdafccba511540e6db92277aa104a23f57209ac)

Change-Id: Id71602ffb1ec4ab3d777875ebc5c4dc965967e96
Signed-off-by: Francois Marier <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11225
Committed: https://git.mahara.org/mahara/mahara/commit/414fdfeb0b99af85ed97242f26cb235b384eb495
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 414fdfeb0b99af85ed97242f26cb235b384eb495
Author: Martin Langhoff <email address hidden>
Date: Sat Dec 1 23:54:23 2007 +1300

Bug 1890213: remove expensive is_array()

adodb: RecordSet_postgres7->MoveNext() - remove expensive is_array()

And implicit count() of the array keys/columns. This shaves a good 5%
of the exec time of get_records('config')

(cherry picked from commit 4652e5617d9616e3f61e78df5a4c863e16ac5634)

Change-Id: Id83af45bbadc86720c09883f9b753d5e0dc44908
Signed-off-by: Francois Marier <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11224
Committed: https://git.mahara.org/mahara/mahara/commit/06d5be2195b3cb53c8445c884ec6039554f1c05f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 06d5be2195b3cb53c8445c884ec6039554f1c05f
Author: Lisa Seeto <email address hidden>
Date: Mon Sep 7 14:21:34 2020 +1200

Bug 1890213: Upgrade: ADODB 5.20.16 to 5.20.18

Change-Id: I7f41abebbe3e49d5da1241206429a7f400c9cedb
Signed-off-by: Lisa Seeto <email address hidden>