Language menu shows when there's only one language
Bug #1889369 reported by
Peter Spicer
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Won't Fix
|
Low
|
Unassigned | ||
Bug Description
On a fresh 20.04, we've seen cases of the language menu showing up even when only one language is actually present.
The reason is that LANGCHOICES is an array of all possible languages that can be selected, and the test in the template to show/hide the language selector is whether LANGCHOICES is empty or not.
There should be an additional flag for 'show language selector' which is true/false based on whether LANGCHOICES has > 1 entry or not in it.
| Changed in mahara: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| milestone: | none → 20.10.0 |
| tags: | added: bite |
| tags: |
added: bite-sized removed: bite |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #1 |
| no longer affects: | mahara/20.04 |
| no longer affects: | mahara/19.10 |
| Changed in mahara: | |
| milestone: | 21.04.0 → none |
| milestone: | none → 21.04.0 |
| no longer affects: | mahara/20.10 |
| Changed in mahara: | |
| assignee: | Cecilia Vela Gurovic (ceciliavg) → nobody |
Revision history for this message
| Robert Lyon (robertl-9) wrote | #2 |
| Changed in mahara: | |
| status: | In Progress → Won't Fix |
| Changed in mahara: | |
| milestone: | 21.04.0 → none |
To post a comment you must log in.
Patch for "master" branch: https:/