Theme colour contrast fails for <code> tag

Bug #1885046 reported by Lisa Seeto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

There appears to be a <code> tag used throughout Mahara which has styling that is failing contrast checks.
When inspecting an element inside of <code> tags, the styling is as follows:
code {
    font-size: 87.5%;
    color: #e83e8c;
    word-break: break-word;
}

The colour values are failing the colour contrast for normal text in this tool found here: https://webaim.org/resources/contrastchecker/

The <code> tag features in these places:
Admin menu -> Configure site -> Site options -> Security settings help text for:
pathtoclam,
pathtofile,
remoteavatars,
viruschecking

Admin menu -> Extensions -> Plugin administration -> Elasticsearch help text:
affecting 11 files (all of the help text files)

The styling of the <code> will need to be either updated, or perhaps discarded in favour of a different element and class instead.

Revision history for this message
Lisa Seeto (lisaseeto) wrote :
Revision history for this message
Lisa Seeto (lisaseeto) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11054

Changed in mahara:
status: New → Triaged
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11054
Committed: https://git.mahara.org/mahara/mahara/commit/c8f9aefbface99553bd411f9399b2a7a45246c66
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c8f9aefbface99553bd411f9399b2a7a45246c66
Author: Evonne <email address hidden>
Date: Fri Jul 3 10:16:33 2020 +1200

Bug1885046 Theme colour contrast for <code> tag

Changed the value of $pink in bootstrap in raw to pass contrast.

behatnotneeded

Change-Id: Id295e302a033f187e9520465976e38bfc6176b5f

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 20.10.0
status: Triaged → Fix Committed
importance: Undecided → Medium
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.