Missing Help Text Icon: admin/site/menu.php

[Lisa Seeto]

The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus.

To replicate:
1. Log into Mahara as a site admin
2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus
3. Set the Keyboard focus to the the radio button for "External link"
4. Navigate the keyboard focus (tab once) and press enter
5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it
This happens with "Site file" as well.

Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links.

Versions: Mahara 20.04, 19.10 19.04

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11179

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11179
Committed: https://git.mahara.org/mahara/mahara/commit/f8f78e8a685928f03ff757cb4306368e1e69bb99
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f8f78e8a685928f03ff757cb4306368e1e69bb99
Author: Lisa Seeto <email address hidden>
Date: Tue Aug 25 15:09:28 2020 +1200

Bug 1883803: Missing Help Text Icon: admin/site/menu.php

- added in missing quotation mark

Change-Id: I6de86ee38fe7a362294e770996177261818ed0bd
Signed-off-by: Lisa Seeto <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11182

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11183

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11183
Committed: https://git.mahara.org/mahara/mahara/commit/4d152d4c0c0f5d627c481ccec6fef572d551150d
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 4d152d4c0c0f5d627c481ccec6fef572d551150d
Author: Lisa Seeto <email address hidden>
Date: Tue Aug 25 15:09:28 2020 +1200

Bug 1883803: Missing Help Text Icon: admin/site/menu.php

- added in missing quotation mark

Change-Id: I6de86ee38fe7a362294e770996177261818ed0bd
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit f8f78e8a685928f03ff757cb4306368e1e69bb99)

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11184

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11184
Committed: https://git.mahara.org/mahara/mahara/commit/018cdcc084def62809645e5461aed27936a09bb2
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 018cdcc084def62809645e5461aed27936a09bb2
Author: Lisa Seeto <email address hidden>
Date: Tue Aug 25 15:09:28 2020 +1200

Bug 1883803: Missing Help Text Icon: admin/site/menu.php

- added in missing quotation mark

Change-Id: I6de86ee38fe7a362294e770996177261818ed0bd
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit f8f78e8a685928f03ff757cb4306368e1e69bb99)
(cherry picked from commit 4d152d4c0c0f5d627c481ccec6fef572d551150d)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11182
Committed: https://git.mahara.org/mahara/mahara/commit/59ae6daebd208d9701ce67491e915c53ae3e3fbf
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 59ae6daebd208d9701ce67491e915c53ae3e3fbf
Author: Lisa Seeto <email address hidden>
Date: Tue Aug 25 15:09:28 2020 +1200

Bug 1883803: Missing Help Text Icon: admin/site/menu.php

- added in missing quotation mark

Change-Id: I6de86ee38fe7a362294e770996177261818ed0bd
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit f8f78e8a685928f03ff757cb4306368e1e69bb99)