page owner can delete comment after page was released

[Cecilia Vela Gurovic]

A page owner can submit the page to a group, someone else makes a comment on it and after the page was released the owner can delete the comment, even if it's a private comment (has not been published yet by the owner of the comment) the owner can see the comment and delete it.

To test:
- Student submits a collection for review to a Mahara group.
- Instructor posts a comment.
- An edit icon (pencil) is visible for 10 minutes.
- After 10 minutes the edit icon disappears.
- No other icons / options appear against that comment (i.e. there's no option to delete the comment)
- When the collection is released back to the student the option to delete the comment (trash bin icon) is visible.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11040

[Marie Salter (marisal)]

I am not sure this Bug is flagged correctly.

The issue we have encountered is not that a page owner can delete comment after page was released, rather that an instructor, who has posted a comment on a student collection, cannot delete that comment after 10 minutes if, for example, they realise they have posted a comment to the wrong collection - or if they have spotted a typo in their comment. This is all before they release the collection back to the student.

This would seem to be extraordinary functionality if it is deliberate and we are getting a number of complaints about it?

[Kristina Hoeppner (kris-hoeppner)]

Hi Marie,

It is correct that a portfolio owner can delete comments. The person who left the comment will receive a notification.

The portfolio owner is informed about a new comment pretty much right away. The 10 minute limit (or until the next comment is posted if that happens earlier) is there to give the feedback giver the opportunity to correct typos and such, but it's not meant as a complete safety net. Comments are not held back until the portfolio is released.

There is a proposal waiting to be implemented to allow for bulk feedback of submitted portfolios, which then could also include the deleting of feedback before it is sent to students: https://wiki.mahara.org/wiki/Proposals/Scheduled_Bulk_Feedback