Importing page with embedded image not working in all cases

Bug #1871018 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
18.10
High
Unassigned
19.04
High
Unassigned
19.10
High
Unassigned
20.04
High
Unassigned

Bug Description

If I have
- User A that has
- A page, Page A, that has
- A text block on it called Block A
- And in that block some text and an embedded image (using tinymce image selector)

And I export Page A

Then I import it into User B I can see the newly created page has a copy of the embedded image in it.

However if I go to another site and import it into User C the embedded image is not present in the page - It is present in the files area though - but just not hooked up to the text block.

The reason for this is the creating of the text block from imported Leap2A want to match on the <img> tag containing the same url domain as the current site.

When it needs to be more flexible that this

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 20.04rc1
importance: Undecided → High
status: New → In Progress
Revision history for this message
Robert Lyon (robertl-9) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10854
Committed: https://git.mahara.org/mahara/mahara/commit/c57fe9bdf1ec3f231926d03db3a8667aee6446d1
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit c57fe9bdf1ec3f231926d03db3a8667aee6446d1
Author: Robert Lyon <email address hidden>
Date: Mon Apr 6 14:19:01 2020 +1200

Bug 1871018: Embedded image not connecting correctly

When imported Leap2A page with text block containing an embedded image
<img> tag with a src URL from another site

Change-Id: Icfed626a69cbde20fa891f830745b893f29c6ad2
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10880

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10880
Committed: https://git.mahara.org/mahara/mahara/commit/3cb6ea75cb4bfca32d55d6d64c08b299d299044c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 3cb6ea75cb4bfca32d55d6d64c08b299d299044c
Author: Robert Lyon <email address hidden>
Date: Mon Apr 6 14:19:01 2020 +1200

Bug 1871018: Embedded image not connecting correctly

When imported Leap2A page with text block containing an embedded image
<img> tag with a src URL from another site

Change-Id: Icfed626a69cbde20fa891f830745b893f29c6ad2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c57fe9bdf1ec3f231926d03db3a8667aee6446d1)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10881

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10881
Committed: https://git.mahara.org/mahara/mahara/commit/b1d8a0e6337ab05903b84b1d708ad6d52d4750c9
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit b1d8a0e6337ab05903b84b1d708ad6d52d4750c9
Author: Robert Lyon <email address hidden>
Date: Mon Apr 6 14:19:01 2020 +1200

Bug 1871018: Embedded image not connecting correctly

When imported Leap2A page with text block containing an embedded image
<img> tag with a src URL from another site

Change-Id: Icfed626a69cbde20fa891f830745b893f29c6ad2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c57fe9bdf1ec3f231926d03db3a8667aee6446d1)
(cherry picked from commit 3cb6ea75cb4bfca32d55d6d64c08b299d299044c)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10882

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10882
Committed: https://git.mahara.org/mahara/mahara/commit/6a196dce436d03dae8eeeaf060da40a6482583e7
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit 6a196dce436d03dae8eeeaf060da40a6482583e7
Author: Robert Lyon <email address hidden>
Date: Mon Apr 6 14:19:01 2020 +1200

Bug 1871018: Embedded image not connecting correctly

When imported Leap2A page with text block containing an embedded image
<img> tag with a src URL from another site

Change-Id: Icfed626a69cbde20fa891f830745b893f29c6ad2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c57fe9bdf1ec3f231926d03db3a8667aee6446d1)
(cherry picked from commit 3cb6ea75cb4bfca32d55d6d64c08b299d299044c)
(cherry picked from commit b1d8a0e6337ab05903b84b1d708ad6d52d4750c9)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10889

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10889
Committed: https://git.mahara.org/mahara/mahara/commit/ae671d36a2c49f34315a04203f23b293cb4e4cd1
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit ae671d36a2c49f34315a04203f23b293cb4e4cd1
Author: Robert Lyon <email address hidden>
Date: Mon Apr 6 14:19:01 2020 +1200

Bug 1871018: Embedded image not connecting correctly

When imported Leap2A page with text block containing an embedded image
<img> tag with a src URL from another site

Change-Id: Icfed626a69cbde20fa891f830745b893f29c6ad2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c57fe9bdf1ec3f231926d03db3a8667aee6446d1)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04.0 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers