Tidy up the artefact attachments_from_id_list() function

[Robert Lyon]

There are a bunch of places that call this function and then straight after do a loop to add a file icon

We should do the adding of the file icon within the call to attachments_from_id_list()
eg:

htdocs/artefact/resume/lib.php:2088
htdocs/artefact/blog/lib.php:1051
htdocs/artefact/comment/lib.php:511
htdocs/artefact/internal/notes.php:167
htdocs/artefact/internal/notes.json.php:167

Also there are a bunch of places where we don't even call the function and just duplicate it:

htdocs/artefact/resume/composite.json.php:
htdocs/artefact/resume/lib.php
htdocs/artefact/blog/blocktype/recentposts/lib.php:

These should be fixed to use the function we already have

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10954

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10954
Committed: https://git.mahara.org/mahara/mahara/commit/9cecf19dcef8e7146a0ca997a015d6016eb44a06
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9cecf19dcef8e7146a0ca997a015d6016eb44a06
Author: Lisa Seeto <email address hidden>
Date: Mon May 4 10:52:45 2020 +1200

Bug 1867822: Tidy up the artefact attachments_from_id_list() function

- alter files to use attachments_from_id_list()
- alter attachments_from_id_list func params

Change-Id: I32b26586deb2f2a1b6a624f2c7afc4520a1a57ff
Signed-off-by: Lisa Seeto <email address hidden>

[Robert Lyon (robertl-9)]

This tidying up of code actually fixed a couple of errors where the image attachment icon was not showing for recentposts / notes when view another's page as normal user