Display people from own institution(s) first when searching for them during portfolio sharing

Bug #1857935 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Lisa Seeto

Bug Description

On a multi-tenanted site it can happen easily that people have the same name. Often, we want to find people from our own institution.

• The display of the search results is changed to display people from one's own institution(s) first and only then display people from other institutions;
• The institution name is displayed in the search results to distinguish the people from one's own institution to others:

People in "Institution name"
...
...
...
...

Other people

Careful when people are in multiple institutions. If possible, we could say: "People in my institutions" instead rather than listing all of them, in case someone is in very many institutions.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10759

Lisa Seeto (lisaseeto)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10764

Lisa Seeto (lisaseeto)
Changed in mahara:
assignee: nobody → Lisa Seeto (lisaseeto)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10759
Committed: https://git.mahara.org/mahara/mahara/commit/75a96408975052001eee7caa711fe8c005d34c85
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 75a96408975052001eee7caa711fe8c005d34c85
Author: Lisa Seeto <email address hidden>
Date: Fri Feb 14 14:12:43 2020 +1300

Bug 1857935: Display people from own
institution(s) first when searching for them during portfolio sharing

- added in check when searching users to display users in institutions first
- added in select2js datasource formating to get user dropdown categories
- limit the type of data returned in ajax calls to limit data risks (Bug 1863043)
- refactor json and tpl
- refactor sql, show institution display name

Change-Id: I478a4d9534bf1de820ca59d60ca7768685e36a96
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10769
Committed: https://git.mahara.org/mahara/mahara/commit/043aead9123f674a8205ab287b9ba92585999ee1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 043aead9123f674a8205ab287b9ba92585999ee1
Author: Lisa Seeto <email address hidden>
Date: Mon Feb 24 14:13:21 2020 +1300

Bug 1857935: Behat Tests

- add new step definition select_from_nested_search_box
- alter tests to call new step
- alter target of user name to display name

Change-Id: I3d53594a42feae2922ee7297a78efdb5e9bff04b
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10764
Committed: https://git.mahara.org/mahara/mahara/commit/8622f1902ee2f8103fa16f0dd250b87ce0fde9ca
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8622f1902ee2f8103fa16f0dd250b87ce0fde9ca
Author: Evonne <email address hidden>
Date: Tue Feb 18 14:42:03 2020 +1300

Bug 1857935 Share dropdown styling

Fix now forces the dropdown box to be wider to fit in the longest
unwrapped line, and has margin on left to align all text away from
usericon, and a margin on right to stop horizontal scroll. The name
is regular weight, and the rest of the info are in a lighter weight.
- added in stylings for text for secondary information (email etc...)

behatnotneeded

Change-Id: I852b4f9364e8932064029d44652dd191c38926cf

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 20.04.0
tags: added: nominatedfeature
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.