Allow Artefact File save_file() function to save image as profileicon if needed

Bug #1857366 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Unassigned

Bug Description

Currently the save_file() function detects if the file is an image and saves it thus.

But if you want the image file to be saved as a profile icon it can't do that.

So will adjust it so that if you pass in 'profileicon' as artefacttype in the $data object it will save the image as profileicon instead

Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → Wishlist
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10690

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10691

Changed in mahara:
milestone: none → 20.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10691
Committed: https://git.mahara.org/mahara/mahara/commit/631ac26e901f2fdd215f949d14c0546683158c56
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 631ac26e901f2fdd215f949d14c0546683158c56
Author: Robert Lyon <email address hidden>
Date: Tue Dec 24 08:09:34 2019 +1300

Bug 1857366: Allow saml auth to set profileicon on creation

If the IdP supplies a base64 image string

behatnotneeded

Change-Id: I7bfe66f3ad5995e16c02ace7acae403aca939dea
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10690
Committed: https://git.mahara.org/mahara/mahara/commit/9330ccd3ef8a552afd990b11936b3cf6ad31ddf5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 9330ccd3ef8a552afd990b11936b3cf6ad31ddf5
Author: Robert Lyon <email address hidden>
Date: Tue Dec 24 07:42:59 2019 +1300

Bug 1857366: Allow save_file() to make profileicon rather than image

If we specify the artefacttype = 'profileicon'

behatnotneeded

Change-Id: I20aaa0c5176427abab3564fdf7c267617e6e81b7
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.