Get site options form to reload page on updating certain fields

Bug #1854421 reported by Robert Lyon on 2019-11-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

When we update the language or theme fields it's not obvious that things have changed

We get a saved success message but things still look the same - we need to then refresh the page to see the changes.

This can be a bit confusing.

We had some code in the past to reload the page if certain field were filled in - by making the form submit in a non js way. But this got broken and trying to fix that breaks other things.

So instead I will get it working by applying the reload after the page save, with an 'Applying changes' popup to appear for a second before the page reloads

Robert Lyon (robertl-9) on 2019-11-29
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 20.04.0
tags: added: regression
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)

Reviewed: https://reviews.mahara.org/10630
Committed: https://git.mahara.org/mahara/mahara/commit/7e5f3f60c489ca8db13d989cd0cc94011c8988ba
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7e5f3f60c489ca8db13d989cd0cc94011c8988ba
Author: Robert Lyon <email address hidden>
Date: Fri Nov 29 15:52:05 2019 +1300

Bug 1854421: Allow site form to reload page on save

If certain fields are changed, like theme / language.
As we can't 'see' the changes until we reload the page.

We used to have some code to reload the page if theose fields changed
but it go broken over the years. This tries to fix that.

Change-Id: I62b6740bbdd2757752a21a18e3d76fb0cefcf4d6
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2020-01-07
Changed in mahara:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers