LTI duplicate email addresses causing problems

Bug #1851155 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
18.10
Fix Released
High
Unassigned
19.04
Fix Released
High
Unassigned
19.10
Fix Released
High
Unassigned
20.04
Fix Released
High
Unassigned

Bug Description

When the user had duplicate email addresses it would result in a login failure.

<EXCEPTION class="WebserviceInvalidParameterException">
<ERRORCODE>invalidparameter</ERRORCODE>
<MESSAGE>Invalid parameter value detected; execution cannot continue. : Username "<email address hidden>" is not valid.</MESSAGE>
</EXCEPTION>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10555

Revision history for this message
Robert Lyon (robertl-9) wrote :

If we have a moodle -> mahara connection with both mnet and lti enabled then if the following things are done in this order:

1) Create a new user in moodle and add them to the course that has an assignment submission via LTI
2) Login to moodle and then follow the assignment submissiion link
- this creates the user

3) Logout from mahara
4) Login to moodle as user and follow the 'Network servers' link to mahara
- if this is set to use username then it creates a new user rather than log them into the existing account
5) Logout from mahara
6) Login to moodle and then follow the assignment submissiion link you get the
<?xml version="1.0" encoding="UTF-8" ?>
<EXCEPTION class="WebserviceInvalidParameterException">
<ERRORCODE>invalidparameter</ERRORCODE>
<MESSAGE>Invalid parameter value detected; execution cannot continue. : Username &quot;<email address hidden>&quot; is not valid.</MESSAGE>
</EXCEPTION>

Revision history for this message
Robert Lyon (robertl-9) wrote :

Note it is important to set up the institution correctly - the xmlrpc should not have parent auth set if the lti has xmlrpc set as parent auth

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

This is an edge case and we don't cater for running MNet and LTI in parallel.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10555
Committed: https://git.mahara.org/mahara/mahara/commit/de23398bfe5f9c17bc3c60344e57f27437dfc3e0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit de23398bfe5f9c17bc3c60344e57f27437dfc3e0
Author: Matt Clarkson <email address hidden>
Date: Fri Nov 1 09:44:02 2019 +1300

Bug 1851155: module/lti - fixed login error

Duplicate email addresses resulted in login failure

behatnotneeded

Change-Id: Ia52fc91b43f6769844efd3f4aad57258becbbc75

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10775

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10775
Committed: https://git.mahara.org/mahara/mahara/commit/dcb7dc1ae845c2192a98da6bed27bf8ec4b3fbd2
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit dcb7dc1ae845c2192a98da6bed27bf8ec4b3fbd2
Author: Matt Clarkson <email address hidden>
Date: Fri Nov 1 09:44:02 2019 +1300

Bug 1851155: module/lti - fixed login error

Duplicate email addresses resulted in login failure

behatnotneeded

Change-Id: Ia52fc91b43f6769844efd3f4aad57258becbbc75
(cherry picked from commit de23398bfe5f9c17bc3c60344e57f27437dfc3e0)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10776

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10776
Committed: https://git.mahara.org/mahara/mahara/commit/262ac52c51c04363afec2b843875c9001c529f5c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 262ac52c51c04363afec2b843875c9001c529f5c
Author: Matt Clarkson <email address hidden>
Date: Fri Nov 1 09:44:02 2019 +1300

Bug 1851155: module/lti - fixed login error

Duplicate email addresses resulted in login failure

behatnotneeded

Change-Id: Ia52fc91b43f6769844efd3f4aad57258becbbc75
(cherry picked from commit de23398bfe5f9c17bc3c60344e57f27437dfc3e0)
(cherry picked from commit dcb7dc1ae845c2192a98da6bed27bf8ec4b3fbd2)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10777

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10777
Committed: https://git.mahara.org/mahara/mahara/commit/a21a60dc4ffe69aae7e5fa8fb44aaa52044c9c43
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit a21a60dc4ffe69aae7e5fa8fb44aaa52044c9c43
Author: Matt Clarkson <email address hidden>
Date: Fri Nov 1 09:44:02 2019 +1300

Bug 1851155: module/lti - fixed login error

Duplicate email addresses resulted in login failure

behatnotneeded

Change-Id: Ia52fc91b43f6769844efd3f4aad57258becbbc75
(cherry picked from commit de23398bfe5f9c17bc3c60344e57f27437dfc3e0)
(cherry picked from commit dcb7dc1ae845c2192a98da6bed27bf8ec4b3fbd2)
(cherry picked from commit 262ac52c51c04363afec2b843875c9001c529f5c)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10781

Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers