iPad iOS 13.1 block comments and details modal content scrolls horizontally

Bug #1850865 reported by Rangi Daymond
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned
19.10
Medium
Unassigned

Bug Description

- Code/Gerrit: latest 19.10 on master.dev.mahara.org
- Platform tested: iPad Air 2 --> iOS 13.1 and Safari
                   does NOT occur on the Android 5.1 and Chrome tablet
- Theme: Modern

Preconditions:

1. PersonA has at least one page that has an image block with comments 'On'.

Test steps:

1. PersonA is logged in and selects to display their page.
2. PersonA selects to view the image Comments and details modal.
3. The Comments and details modal opens on the right hand side of the display - the user can scroll up & down (i.e. vertically) in the modal. ✘ The user can scroll horizontally (see attached screen shot).

Revision history for this message
Rangi Daymond (rangid) wrote :
Rangi Daymond (rangid)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10552

Revision history for this message
Rangi Daymond (rangid) wrote :

Tested fix in master.dev environment and left-right scrolling no longer possible in the Comments and details modal when viewed via the iPad Air2 using Safari.
Also checked on my laptop using Firefox and Chrome.

***Will check Android-Chrome and re-check iOS-Safari once deployed to master.

Revision history for this message
Rangi Daymond (rangid) wrote :

- Code/Gerrit: https://reviews.mahara.org/#/c/10552/ patch 1 of 1
- Platform tested: iPad Air 2 --> iOS 13.1 and Safari tablet
                   Android 5.1 and Chrome tablet
                   Ubuntu 18.04 laptop and Firefox
- Theme: Modern

Preconditions:

1. PersonA has at least one page that has an image block with comments 'On'.

Test steps: repeat the following for each platform

1. PersonA is logged in and selects to display their page.
2. PersonA selects to view the image Comments and details modal.
3. The Comments and details modal opens on the right hand side of the display, PersonA can:
   3.1 scroll up & down (i.e. vertically) in the modal to read the comments and content ✔
   3.2 NOT scroll horizontally (i.e. left to right) in the modal ✔
   3.3 close the modal after veiwing the content ✔
   3.4 add their own comment and return to edit it after saving it. ✔
QA approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10552
Committed: https://git.mahara.org/mahara/mahara/commit/2343cb6d93292f5253139ecb0897f8af0b035d34
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2343cb6d93292f5253139ecb0897f8af0b035d34
Author: Evonne <email address hidden>
Date: Fri Nov 1 13:17:05 2019 +1300

Bug #1850865 ipad iOS 13.1 modal scrolls horizontally

- put in overflow-x: hidden in modal body

behatnotneeded

Change-Id: I4937825db1bc0c6cb4422330c60e43fde230142f

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10588

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10588
Committed: https://git.mahara.org/mahara/mahara/commit/76760fffaf19917f13d2e0020be3b69978a9c361
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 76760fffaf19917f13d2e0020be3b69978a9c361
Author: Evonne <email address hidden>
Date: Fri Nov 1 13:17:05 2019 +1300

Bug #1850865 ipad iOS 13.1 modal scrolls horizontally

- put in overflow-x: hidden in modal body

behatnotneeded

Change-Id: I4937825db1bc0c6cb4422330c60e43fde230142f
(cherry picked from commit 2343cb6d93292f5253139ecb0897f8af0b035d34)

Changed in mahara:
status: Fix Committed → Fix Released
no longer affects: mahara/20.04
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers