Only mention ssphp needs updating if installed

Bug #1847345 reported by Robert Lyon on 2019-10-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
18.10
High
Unassigned
19.04
High
Unassigned

Bug Description

When we move to v1.17.6 some of the classes are different and so we need to warn user to upgrade the ssphp.

But we don't need to do the warning if ssphp is not installed

Robert Lyon (robertl-9) wrote :

To test this

1)
- have 19.04 site
- run: make cleanssphp && ssphp
(to get rid of and then install ssphp)
- then upgrade to patch - should see the warning message about needing to upgrade ssphp

2)
- have 19.04 site
- run: make cleanssphp
(to get rid of ssphp)
- then upgrade to patch - should NOT see the warning message about needing to upgrade ssphp

Robert Lyon (robertl-9) on 2019-10-08
Changed in mahara:
status: New → In Progress
importance: Undecided → High
milestone: none → 19.10.0

The command to run is:

make cleanssphp && make ssphp

Reviewed: https://reviews.mahara.org/10426
Committed: https://git.mahara.org/mahara/mahara/commit/2db711ad4e036dcbb3f76b2e18caae4c0c3f364d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2db711ad4e036dcbb3f76b2e18caae4c0c3f364d
Author: Robert Lyon <email address hidden>
Date: Wed Oct 9 09:17:21 2019 +1300

Bug 1847345: Only mention we need to update simplesamlphp if installed

behatnotneeded

Change-Id: Id54baa5be70dc81071a918762dd42b5c73548e7b
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2019-10-08
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10560

Robert Lyon (robertl-9) on 2019-11-04
no longer affects: mahara/19.10

Reviewed: https://reviews.mahara.org/10560
Committed: https://git.mahara.org/mahara/mahara/commit/79cf0b295709cf4045376d3ce6d77d102741756c
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 79cf0b295709cf4045376d3ce6d77d102741756c
Author: Robert Lyon <email address hidden>
Date: Wed Oct 9 09:17:21 2019 +1300

Bug 1847345: Only mention we need to update simplesamlphp if installed

behatnotneeded

Change-Id: Id54baa5be70dc81071a918762dd42b5c73548e7b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 2db711ad4e036dcbb3f76b2e18caae4c0c3f364d)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10559
Committed: https://git.mahara.org/mahara/mahara/commit/11d4c42253edf2324dd6eec0dba90237856e5a6e
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 11d4c42253edf2324dd6eec0dba90237856e5a6e
Author: Robert Lyon <email address hidden>
Date: Wed Oct 9 09:17:21 2019 +1300

Bug 1847345: Only mention we need to update simplesamlphp if installed

behatnotneeded

Change-Id: Id54baa5be70dc81071a918762dd42b5c73548e7b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 2db711ad4e036dcbb3f76b2e18caae4c0c3f364d)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers