Move "Display page" and "Return to pages and collections" to right-hand side on "Edit" screen

[Kristina Hoeppner]

For Mahara 19.10 we moved all buttons on the edit screen of a page to the right-hand side. However, the "Display page" link at the top and "Display page" button and the "Return to pages and collections" / "Return to {group | institution | site} pages and collections" button are still in the same position making for an awkward navigation.

It would be better if both "Display page" and "Return to pages and collections" were on the right-hand side below the "Share" button. That way we would also resolve needing to scroll up or down on long pages to get to them.

Font Awesome icon for the "Display page" button: "tv"
Font Awesome icon for "Return to pages and collections" button: step-backward

Both icons need to be keyboard accessible and have tool tips "Display page" and "Return to pages and collections" respectively. "Return to..." would be:

Return to pages and collections
Return to group pages and collections
Return to institution pages and collections
Return to site pages and collections

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10375

[Lisa Seeto (lisaseeto)]

After offline discussion, the requirements are now:

The idea was instead to change the icon of the "Edit" button when in edit mode to the "Display page" icon and not have a separate "Display page" icon but only the "Return to pages and collections" one.

So that when you are in display mode, you see the pencil for editing -> press it -> Edit mode comes up and the highlighted icon has the screen icon on it -> Press it and you are returned to display mode.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10375
Committed: https://git.mahara.org/mahara/mahara/commit/466b4a8a2c013d3c697af612029da4f591e5f3bd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 466b4a8a2c013d3c697af612029da4f591e5f3bd
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 24 16:04:42 2019 +1200

Bug 1844470: Move "Display page" and "Return to pages and collections"
to right-hand side on "Edit" screen

- create new edit page action buttons for return to <location> button
- delete references to the old display page link created in file editviewtabs.tpl
- delete file editviewtabs.tpl
- change the edit button in editviewpageactions.tpl into a display button
- change behat tests to reflect the change from Edit to Display page
- change the Behat instruction for And I display the page to target updated element
- delete the old display button styling from the style guide
- move url, title display logic into new func get_return_to_url_and_title in lib/view.php
- adjust blocks.php, access.php, editlayout.php to assign url, title using new func

behatnotneeded

Change-Id: Iedf2882c42fa1d204e438a23842834fbb9a709f9
Signed-off-by: Lisa Seeto <email address hidden>