Check skin before when copying a page

[Cecilia Vela Gurovic]

When creating a site/group/institution page, we should not be allowing to choose from "My skins".

When copying a page, there should be a check to see if the user that wants to copy has access to the skin. If not, the skin should not be included in the new page.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10351

[Robert Lyon (robertl-9)]

I was going to write up which pages should get which skin types but the current system seems to be fine to me.

Is there a reason why we want to restrict certain skins from site/institution/group pages?

[Kristina Hoeppner (kris-hoeppner)]

The personal skins are owned by a person and thus are not accessible when a page is copied into a group. When another group member wants to edit the page, e.g. the page title, they can't and it's due to the skin having been a private one. Thus, the removal of the skin to prevent issues in other contexts.

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12080

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12080
Committed: https://git.mahara.org/mahara/mahara/commit/4d0074d5b1262cd72bbcd0f4e3a8097f2c513fb1
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 4d0074d5b1262cd72bbcd0f4e3a8097f2c513fb1
Author: Kevin Dibble <email address hidden>
Date: Tue Sep 17 16:52:24 2019 +1200

Bug 1844199: My Skins to not appear.

When creating a group, site or institute page
to not show the users personal skins.

behatnotneeded

Change-Id: I3cea0e86cf884a8e1183147d9038147401885c22
Signed-off-by: Robert Lyon <email address hidden>