Stop the slideshow from scrolling when arrow are clicked

Bug #1837953 reported by Robert Lyon on 2019-07-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned
19.04
Medium
Unassigned
19.10
Medium
Unassigned

Bug Description

This is a bug introduced in 19.04.1+

Where the carousel arrows are causing scrolling on page

This is caused by the fix for bug https://bugs.launchpad.net/mahara/+bug/1833390

See https://mahara.org/interaction/forum/topic.php?id=8490&offset=0&limit=10#post33859

Steven (stevens-q) wrote :

Commit hash: 08d18c8e306e30904d579509be767af70a65500d
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara User1 exists (no roles)
2) Portfolio page exists with an Image gallery block
3) Image gallery block set up as follows:
    a) gallery has 5 images
    b) Style = Slideshow
    c) Width = 600
    d) Retractable = No

TEST STEPS:
------------------------
1) Log in as Mahara User1
2) View the portfolio page as mentioned above
3) Click the advance "chevron icons" to the right
4) Verify that the portfolio page does not scroll up or down ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/10225
Committed: https://git.mahara.org/mahara/mahara/commit/08d18c8e306e30904d579509be767af70a65500d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 08d18c8e306e30904d579509be767af70a65500d
Author: Robert Lyon <email address hidden>
Date: Fri Jul 26 11:15:30 2019 +1200

Bug 1837953: Stop slideshow anchor links scrolling

Now that we scroll in page anchor links via js

Change-Id: Ic4c0eec2fe75ff6c2e66a081c456043888fa502f
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/10229
Committed: https://git.mahara.org/mahara/mahara/commit/34a2c2dfbc3712fd2e7ae9726369d75b20978350
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 34a2c2dfbc3712fd2e7ae9726369d75b20978350
Author: Robert Lyon <email address hidden>
Date: Fri Jul 26 11:15:30 2019 +1200

Bug 1837953: Stop slideshow anchor links scrolling

Now that we scroll in page anchor links via js

Change-Id: Ic4c0eec2fe75ff6c2e66a081c456043888fa502f
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 08d18c8e306e30904d579509be767af70a65500d)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers