Error in Ldap user sync

Bug #1837660 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
18.04
Fix Released
High
Unassigned
18.10
Fix Released
High
Unassigned
19.04
Fix Released
High
Unassigned
19.10
Fix Released
High
Unassigned

Bug Description

When there is an existing matching email on the artefact_internal_profile_email but not on the usr.email field there is an error thrown on line 1334 of auth/ldap/lib.php

 EXECUTE("SELECT * FROM "usr" WHERE "id" = ? LIMIT 2")Command was: SELECT * FROM "usr" WHERE "id" = ?

See https://mahara.org/interaction/forum/topic.php?id=8483&offset=0&limit=10#post33840

This is because we only check for email and return boolean and then try to fetch info based on an object.

Will fix

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10221

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10221
Committed: https://git.mahara.org/mahara/mahara/commit/99cab79133929bb202a78780eab9420e73fe3c21
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 99cab79133929bb202a78780eab9420e73fe3c21
Author: Robert Lyon <email address hidden>
Date: Wed Jul 24 08:08:10 2019 +1200

Bug 1837660: Need to return id to do subsequent query

So that the correct user is fetched

behatnotneeded

Change-Id: I59bb680f7b450bf2fb40256a44fae4a2413590f2
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10233

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10234

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10235

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10235
Committed: https://git.mahara.org/mahara/mahara/commit/a6d9a4854578d195b79791f0591b04166f7bf6ab
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit a6d9a4854578d195b79791f0591b04166f7bf6ab
Author: Robert Lyon <email address hidden>
Date: Wed Jul 24 08:08:10 2019 +1200

Bug 1837660: Need to return id to do subsequent query

So that the correct user is fetched

behatnotneeded

Change-Id: I59bb680f7b450bf2fb40256a44fae4a2413590f2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 99cab79133929bb202a78780eab9420e73fe3c21)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10234
Committed: https://git.mahara.org/mahara/mahara/commit/0f5a0f71d88c8a29b9468c94dccb8de075c12907
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 0f5a0f71d88c8a29b9468c94dccb8de075c12907
Author: Robert Lyon <email address hidden>
Date: Wed Jul 24 08:08:10 2019 +1200

Bug 1837660: Need to return id to do subsequent query

So that the correct user is fetched

behatnotneeded

Change-Id: I59bb680f7b450bf2fb40256a44fae4a2413590f2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 99cab79133929bb202a78780eab9420e73fe3c21)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10233
Committed: https://git.mahara.org/mahara/mahara/commit/fba0aa6727215bf62f3645e3b7e4bb7df200d34a
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit fba0aa6727215bf62f3645e3b7e4bb7df200d34a
Author: Robert Lyon <email address hidden>
Date: Wed Jul 24 08:08:10 2019 +1200

Bug 1837660: Need to return id to do subsequent query

So that the correct user is fetched

behatnotneeded

Change-Id: I59bb680f7b450bf2fb40256a44fae4a2413590f2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 99cab79133929bb202a78780eab9420e73fe3c21)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers