Skins to support new page header

[Ghada El-Zoghbi]

Mahara: 19.04.0
OS: Linux 16.04
DB: Postgers
Browser: FF / Chrome

The skin is not respecting the new pageheader of a page.

To reproduce - Repeat only horizontally:

1. Create a new skin (Skin1):
- Add a Background image (attached)
- Background image report = Repeat only horizontally
- Background image attachment = Fixed
- Background image position = Top
- Save

2. Create a new page that uses this new skin (Skin1)
- Page title = Skin Test
- Current skin = Skin1
- Save
- Add any block to the page (i.e. text)

3. Display the page
Results:
The page header (i.e. page banner at top) is displayed across the entire page (from right to left) whereas the rest of the page below the banner has the background image displayed in the right/left margins.

Expected Result:
The page header (i.e. page banner at top) should display the background image in the left/right margin as the rest of the page.

=====

To reproduce - Repeat Vertically:

1. Updated Skin1:
- Background image report = Repeat Vertically
- Save

2. Display (refresh) Skin Test page
Results:
The page header (i.e. page banner at top) is displayed across the entire page (from right to left) whereas the rest of the page below the banner has the background image displayed in the right/left margins.

At the bottom of the page, the image's bottom is seen in the center of the page.

Expected Result:
The page header (i.e. page banner at top) should display the background image in the left/right margin as the rest of the page.

At the bottom of the page, the image's bottom is seen in the center of the page.

=====

To reproduce - Repeat both directions:

1. Updated Skin1:
- Background image report = Repeat both directions
- Save

2. Display (refresh) Skin Test page
Results:
The page header (i.e. page banner at top) is displayed across the entire page (from right to left) whereas the rest of the page below the banner has the background image repeated in the right/left margins and at the bottom of the page.

Expected Result:
The page header (i.e. page banner at top) should display the repeated background image in the left/right margin as the rest of the page and at the bottom of the page.

[Kristina Hoeppner (kris-hoeppner)]

https://reviews.mahara.org/#/c/10197/
https://reviews.mahara.org/#/c/10187/

What is being done:

1. Add background color to header area
2. Add picture to header area (can't be resized in Mahara)
3. Change the tabs in the skin creation screen from "Background" to "Page" and the font and text one to "Text".
4. Add Mahara theme fonts to skin font selection so that the normal font can be retained.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10410

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10410
Committed: https://git.mahara.org/mahara/mahara/commit/0e0ef413b61c451916dc0dc4508c7ed5cd18babc
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0e0ef413b61c451916dc0dc4508c7ed5cd18babc
Author: Robert Lyon <email address hidden>
Date: Sun Oct 6 19:54:33 2019 +1300

Bug 1835869: Remove obsolete skin options

The old options to be removed are:

- header_text_font_color
- header_link_normal_color
- header_link_normal_underline
- header_link_hover_color
- header_link_hover_underline
- header_logo_image
- view_background_color
- view_background_image
- view_background_repeat
- view_background_attachment
- view_background_position
- view_background_width
- view_table_border_color
- view_table_header_color
- view_table_header_text_color
- view_table_odd_row_color
- view_table_even_row_color
- view_button_normal_color
- view_button_hover_color
- view_button_text_color

behatnotneeded

Change-Id: I909e7bcb4f559d9cd052cf4c7b2b80982ecf109c
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10197
Committed: https://git.mahara.org/mahara/mahara/commit/ad7250b706da82231c90230163a99bf323ee5dd4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ad7250b706da82231c90230163a99bf323ee5dd4
Author: Doris Tam <email address hidden>
Date: Fri Jul 19 14:28:54 2019 +1200

Bug 1835869: Add skin background image to page header area

- Created an option in Skin customizing where users may select an image
as their page header
- Reorganised tabs and their titles
- Skin thumbnails display colour/image of header
- drop the old viewbgimg column and add the headingbgimg column

behatnotneeded: to be added later

Change-Id: Ib5bb4714de479e9c10237d24aa653a5ea227a5f7