Adding Journal - message displayed to user is misleading

Bug #1832796 reported by Ghada El-Zoghbi on 2019-06-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Ghada El-Zoghbi
18.04
Medium
Unassigned
18.10
Medium
Unassigned
19.04
Medium
Unassigned
19.10
Medium
Ghada El-Zoghbi

Bug Description

Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF and Chrome

The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so.

To reproduce:
* Create an institution: Inst1

* Add users to Inst1 - user1, admin1

* Create a group for Inst1:
 Associated with institution: Inst1
 Open = No
 Controlled = Yes
 Request = No
 Friend Invitations = Yes
 Create and edit: everyone except ordinary members
 Publicly viewable group = No
 Hide group = Yes
 Hide membership = Hide members
 Hide membership from members = No
 Auto-add users = No
 Shared page notifications = All group members
 Comment notifications = All group members

* Add user1 with role = member to the group

* Add admin1 with role admin

* Log in as user1 and go to group > Journals

* Display message says: There are no journals in this group. Add one.

* Click on 'Add one' link

* User is presented with message they don't have permission.

* Expected: They should not be presented with the link to click 'Add one'.

Changed in mahara:
assignee: nobody → Ghada El-Zoghbi (ghada-z)

Reviewed: https://reviews.mahara.org/10078
Committed: https://git.mahara.org/mahara/mahara/commit/9188fc20704de7ff238da2963276f7b84c9aa6fd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9188fc20704de7ff238da2963276f7b84c9aa6fd
Author: Ghada El-Zoghbi <email address hidden>
Date: Fri Jun 14 14:10:05 2019 +1000

Bug 1832796: Group journals - display add link only if user has permission

For a regular member who does not have permission to
add a journal to a group, the display message should
not include the 'Add one' link.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72

Robert Lyon (robertl-9) on 2019-06-14
Changed in mahara:
importance: Undecided → Medium

Reviewed: https://reviews.mahara.org/10080
Committed: https://git.mahara.org/mahara/mahara/commit/c40945d82fb907ebea53264c0863d3e97c120b87
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit c40945d82fb907ebea53264c0863d3e97c120b87
Author: Ghada El-Zoghbi <email address hidden>
Date: Fri Jun 14 14:10:05 2019 +1000

Bug 1832796: Group journals - display add link only if user has permission

For a regular member who does not have permission to
add a journal to a group, the display message should
not include the 'Add one' link.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72
(cherry picked from commit 9188fc20704de7ff238da2963276f7b84c9aa6fd)

Reviewed: https://reviews.mahara.org/10081
Committed: https://git.mahara.org/mahara/mahara/commit/f6930a7468a46e13c3109d89c449c1a3db5b170a
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit f6930a7468a46e13c3109d89c449c1a3db5b170a
Author: Ghada El-Zoghbi <email address hidden>
Date: Fri Jun 14 14:10:05 2019 +1000

Bug 1832796: Group journals - display add link only if user has permission

For a regular member who does not have permission to
add a journal to a group, the display message should
not include the 'Add one' link.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72
(cherry picked from commit 9188fc20704de7ff238da2963276f7b84c9aa6fd)
(cherry picked from commit c40945d82fb907ebea53264c0863d3e97c120b87)

Reviewed: https://reviews.mahara.org/10082
Committed: https://git.mahara.org/mahara/mahara/commit/81a820d9c7cdcb940376648e06e98457391fc9f4
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 81a820d9c7cdcb940376648e06e98457391fc9f4
Author: Ghada El-Zoghbi <email address hidden>
Date: Fri Jun 14 14:10:05 2019 +1000

Bug 1832796: Group journals - display add link only if user has permission

For a regular member who does not have permission to
add a journal to a group, the display message should
not include the 'Add one' link.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72
(cherry picked from commit 9188fc20704de7ff238da2963276f7b84c9aa6fd)
(cherry picked from commit c40945d82fb907ebea53264c0863d3e97c120b87)
(cherry picked from commit f6930a7468a46e13c3109d89c449c1a3db5b170a)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers