Notification when Importing Leap2A

Bug #1831419 reported by Ghada El-Zoghbi on 2019-06-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 19.10
18.04
High
Unassigned
18.10
High
Unassigned
19.04
High
Unassigned
19.10
High
Unassigned

Bug Description

Mahara: 19.04.04
DB: Postgres
OS: Linux
Browser: FF

When importing a view with a comment block, the following warning is generated:

[WAR] ed (lib/mahara.php:2056) Undefined index: onview
Call stack (most recent first):

    log_message("Undefined index: onview", 8, true, true, "/var/www/mahara/htdocs/lib/mahara.php", 2056) at /var/www/mahara/htdocs/lib/errors.php:520
    error(8, "Undefined index: onview", "/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at /var/www/mahara/htdocs/lib/mahara.php:2056
    handle_event("blockinstancecommit", object(BlockInstance)) at /var/www/mahara/htdocs/blocktype/lib.php:1480
    BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
    View->addblockinstance(object(BlockInstance)) at /var/www/mahara/htdocs/lib/view.php:3400
    View::import_from_config(array(size 12), "2", "leap") at /var/www/mahara/htdocs/import/leap/lib.php:1036
    PluginImportLeap->import_view_from_request(object(stdClass)) at /var/www/mahara/htdocs/import/leap/lib.php:1005
    PluginImportLeap->import_from_requests() at /var/www/mahara/htdocs/import/leap/lib.php:348
    PluginImportLeap->do_import_from_requests() at /var/www/mahara/htdocs/import/index.php:314
    do_import() at /var/www/mahara/htdocs/import/index.php:71

Ghada El-Zoghbi (ghada-z) wrote :

Steps to reproduce:

1. Create a view with a text block and a comment block
2. Export that one view to a Leap2A file
3. Import just this view to Mahara.

Changed in mahara:
status: New → Invalid
Ghada El-Zoghbi (ghada-z) wrote :

Please ignore the steps above. These are the steps to reproduce (logging settings must be set to All).

Steps to reproduce:

1. Enable logging level to 'All' (admin > configure site > site options > Logging settings = 'All')
2. Create a view with a text block and a comment block
3. Export that one view to a Leap2A file
4. Import just this view to Mahara.

Changed in mahara:
status: Invalid → New
Ghada El-Zoghbi (ghada-z) wrote :

This bug was introduced in Bug 1692385 - commit: a3d904e16bb0dbf8621842dafdd0feb9c3c0f9b8

and a small fix in bug 1724113 - commit a8f8a82d8250d7e3f447862c3e48371765f22a9f

Ghada El-Zoghbi (ghada-z) wrote :

The other items to confirm:

1. When a page is shared with a group and a comment is inserted on the page, the event log has recorded this fact: event = sharedcommenttogroup.

2. When entering a comment on a standard page, an event is generated in the event log.

3. When entering a comment on a group page (not shared), an event is generated in the event log.

4. And of course, the warning message no longer appears when importing a page with a comment.

Steven (stevens-q) wrote :

Commit hash: 7040639d50ac68759656d50feb79f0edd4b40f68
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) Enable logging level to 'All' (admin > configure site > site options > Logging settings = 'All')

TEST STEPS:
------------------------
1) Create a view with a text block and a comment block
2) Export that one view to a Leap2A file
3) Import just this view to Mahara.
4) Verify that there are no error messages displayed and portfolio has imported successfully ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/10064
Committed: https://git.mahara.org/mahara/mahara/commit/7040639d50ac68759656d50feb79f0edd4b40f68
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7040639d50ac68759656d50feb79f0edd4b40f68
Author: Ghada El-Zoghbi <email address hidden>
Date: Mon Jun 3 19:43:58 2019 +1000

Bug 1831419: validate insertion of event log for comment

When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea

Robert Lyon (robertl-9) on 2019-06-14
Changed in mahara:
milestone: none → 19.10.0
status: New → Fix Committed
importance: Undecided → High
Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10087

Mahara Bot (dev-mahara) wrote :

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10088

Reviewed: https://reviews.mahara.org/10088
Committed: https://git.mahara.org/mahara/mahara/commit/60bbf50e8eebea2db532584575ec95626b23df98
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 60bbf50e8eebea2db532584575ec95626b23df98
Author: Ghada El-Zoghbi <email address hidden>
Date: Mon Jun 3 19:43:58 2019 +1000

Bug 1831419: validate insertion of event log for comment

When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea
(cherry picked from commit 7040639d50ac68759656d50feb79f0edd4b40f68)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10087
Committed: https://git.mahara.org/mahara/mahara/commit/467f1b0815f9cf72451ba02e18ac358e63e415e0
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 467f1b0815f9cf72451ba02e18ac358e63e415e0
Author: Ghada El-Zoghbi <email address hidden>
Date: Mon Jun 3 19:43:58 2019 +1000

Bug 1831419: validate insertion of event log for comment

When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea
(cherry picked from commit 7040639d50ac68759656d50feb79f0edd4b40f68)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10086
Committed: https://git.mahara.org/mahara/mahara/commit/0ac5ce6daf08c28fbc884a98c17f3781851fef4b
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 0ac5ce6daf08c28fbc884a98c17f3781851fef4b
Author: Ghada El-Zoghbi <email address hidden>
Date: Mon Jun 3 19:43:58 2019 +1000

Bug 1831419: validate insertion of event log for comment

When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea
(cherry picked from commit 7040639d50ac68759656d50feb79f0edd4b40f68)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers