Footer should still be at the bottom of the page on shorter pages

[Liam]

On shorter pages of mahara, the footer hangs in the middle of the page which looks bad.
An example is: /admin/users/institutiontags.php

[Kristina Hoeppner (kris-hoeppner)]

We are extending it to the bottom of the page.

https://reviews.mahara.org/#/c/10308/

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10308
Committed: https://git.mahara.org/mahara/mahara/commit/c9b82dcd898ea623c902d720d363d43cbf5a1681
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c9b82dcd898ea623c902d720d363d43cbf5a1681
Author: Evonne <email address hidden>
Date: Fri Sep 6 15:33:29 2019 +1200

Bug 1830835: Extending page footer colour

Fixes short pages where footer colour stops in a strip rather than
extend to the bottom of the browser window.

behatnotneeded

Change-Id: Ia5968cf0f6926c89a83ed89f3b6bcd196327923c

[Kristina Hoeppner (kris-hoeppner)]

Strangely enough, this patch lost us the shadow around collections on "Pages and collections". Evonne is looking into it.

[Kristina Hoeppner (kris-hoeppner)]

Evonne is fixing this. IE 11 will not have the footer at the bottom of the view port. This is only possible in more modern browsers.

The thing to check in IE 11 is to ensure that the footer is shown. But it doesn't stick to the bottom of the page on short pages.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10326

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10326
Committed: https://git.mahara.org/mahara/mahara/commit/59b8c41e5bb33423345a84398839f46ecd4eba6a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 59b8c41e5bb33423345a84398839f46ecd4eba6a
Author: Evonne <email address hidden>
Date: Tue Sep 10 15:11:08 2019 +1200

Bug 1830835 Footer at bottom of short pages

Reverted commit c9b82dcd898ea623c902d720d363d43cbf5a1681
because it has conflicts with z-index negatives. This fix uses flex
to push footer down to bottom of short pages. Note this fix does
not work on IE11, there the normal footer position is used.

behatnotneeded

Change-Id: I03db6217a235a99191685bda75acaa0dbc9deae0

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10356

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10356
Committed: https://git.mahara.org/mahara/mahara/commit/3414d49ac07374053730f92b977c90f654fa55b8
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3414d49ac07374053730f92b977c90f654fa55b8
Author: Evonne <email address hidden>
Date: Wed Sep 18 16:02:36 2019 +1200

Bug 1830835 Footer at bottom of short pages

Some pages like user profile page where there the content is short,
the previous patch made the content vertically center in the
main-content div. This fix gives the div flex: 1 to tell it to not
do that.

behatnotneeded

Change-Id: I4f8951d799fdbfcb397e46e99592f3f6bd13347e