Messages Sending ignoring user preference

Bug #1830302 reported by Ghada El-Zoghbi on 2019-05-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 19.10
19.04
High
Unassigned
19.10
High
Ghada El-Zoghbi

Bug Description

Mahara: 19.04.0
OS: Linux
DB: Postgres
Browser: FF

There is a bug that was introduced with the isolated institution. It is ignoring the user message preferences.

Scenario:

* User1: set User > Settings > Preferences - 'Messages from other users' = 'Allow people on my friends list to send me messages'

* User2: set User > Settings > Preferences - 'Messages from other users' = 'Allow people on my friends list to send me messages'

* Neither User1 nor User2 are friends of each other

* The site is not set up as isolated institution ($cfg->isolatedinstitutions = false;)

Log in as User1 and attempt to create a message to User1. Mahara allows the message to be sent.

Changed in mahara:
assignee: nobody → Ghada El-Zoghbi (ghada-z)
Steven (stevens-q) wrote :

Commit hash: 28fc80f6ffeb5691ce292682771dbfb7736fed6d
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) Mahara User1 and User2 exist and both have the following set in their preferences
     a) 'Messages from other users' = 'Allow people on my friends list to send me messages'
2) Neither User1 nor User2 are friends of each other
3) The site is not set up as isolated institution ($cfg->isolatedinstitutions = false;)

TEST STEPS:
------------------------
1) Log in as User1 and attempt to create a message to User2. Mahara allows the message to be sent.
2) Verify that user cannot sent a message to User2 who is not a friend

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/10041
Committed: https://git.mahara.org/mahara/mahara/commit/28fc80f6ffeb5691ce292682771dbfb7736fed6d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 28fc80f6ffeb5691ce292682771dbfb7736fed6d
Author: Ghada El-Zoghbi <email address hidden>
Date: Fri May 24 11:50:58 2019 +1000

Bug 1830302: Check if site is set for isolated institutions

When sending a message to another user, the check was
assuming that the site is set up as an isolated
institution and ignoring the user preference for
messages.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I52936cd153336580146a9ac3eaf6e150a0e3affb

Reviewed: https://reviews.mahara.org/10044
Committed: https://git.mahara.org/mahara/mahara/commit/ec0b86db6ec01f4573d3850db32f48664504096b
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit ec0b86db6ec01f4573d3850db32f48664504096b
Author: Ghada El-Zoghbi <email address hidden>
Date: Fri May 24 11:50:58 2019 +1000

Bug 1830302: Check if site is set for isolated institutions

When sending a message to another user, the check was
assuming that the site is set up as an isolated
institution and ignoring the user preference for
messages.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I52936cd153336580146a9ac3eaf6e150a0e3affb
(cherry picked from commit 28fc80f6ffeb5691ce292682771dbfb7736fed6d)

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10067

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers