Create a 'magic' placeholder block

[Robert Lyon]

Goal: Be able to create templates more easily by setting up the basic structure, including block headings, but without the need to choose a specific block type from the start.

See the Mahara Wiki page for more information about what we want to achieve

https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Basic_magic_block

Thanks go to Dublin City University for funding this functionality.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10035

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10038

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10040

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10042

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10070

[Steven (stevens-q)]

Bug - Ux issues with the Block modal
Summary: When the user is viewing the modal flyout window when creating a block for a page, there is no way of knowing what you are about to edit. Some are obvious but others are not ie text of note

[Steven (stevens-q)]

Bug - error displayed when user imports a Leap2a file
Summary: When a user uploads a Leap2a file and has selected which content to save or ignore and presses the import button, an error message is displayed. The import seems to have successfully completed though

[Steven (stevens-q)]

Commit hash: 19dbbea37d7c20691184fe37bf727a49148c85d5
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) Institution One exists
2) Group One exists
3) User exists as follows (No roles User1)
a) Member of Institution One
b) Has a Journal with entries
    c) Has a plan with entries
d) Has files and folders that contain images and text documents
e) Member of Group One -open group and members can create group content
f) User has created a group One topic and has made several posts
4) User exists (No roles User2)

TEST STEPS:
------------------------
1) User1 creates a Portfolio page with all blocks ✔ Some UX issues
2) User1 shares page with public and has allowed users to copy ✔
3) User1 has added page to a time line on various occasions during page creation ✔
4) User1 shares their portfolio p[age with a Group ✔
5) User1 creates a Group ONe portfolio page ✔
6) User1 has exported the page as a Leap2A and HTML export ✔
7) User2 uploads a Leap2A file that was created by User1 ✘
8) User2 views User1's Portfolio page and copies page to their portfolio and adds a block ✔

[Steven (stevens-q)]

Bug - Front end issues on Flyout modal window

Summary: when viewing the Flyoutmodal window using different browsers there are some issues in regards to the display of the content block types cards. see attached screenshot for more details

[Robert Lyon (robertl-9)]

Hi Steven,

Things to test for:

- Versioning: what happens for new / existing pages when placeholder block is added and new version to timeline is created
- Export: What happens when pages / collections with placeholder blocks are exported both as leap2a and html
- Import: what happens when imported for another user. What happens when imported into older site
- Changing placeholder block: What happens when changing placeholder block to another block via config, does it work for all other blocks? Can you place a block on a page type that doesn't allow that type of block?

Cheers
Robert

[Steven (stevens-q)]

Placeholder block testing - add to page
1) Verify user can drag Placeholder block icon (+) to page column ✔
2) Verify that user can click Placeholder block icon (+) and add placeholder through Addblock modal ✔
3) Add page to time line
4) Ammend page - add 2 more modal and add page to time line
5) View the time line
6) Verify that the timeline shows a progression of the page and verify that the blocks are displayed in correct positions
7) Edit place holder block and add page to time line
8) Delete Placeholder block and add page to time line
9) Verify that the timeline shows a progression of the page and verify that the blocks are displayed in correct positions

Export page as HTML file
1) Export page as HTML file
2) save the zip file on local drive
3) Open the index page in a browser
4) Verify that the blocks are displayed as in the original page ✔

Export page as Leap2a
1) Export the page as a leap2a file
2) save the zip file on local drive
3) log into the site as another user and import the leap2a file
4) Verify that the page is now displayed in your portfolio and is displayed as in the original page
5) Verify that the user can edit the Placeholder block ✔
   a) move the Placeholder block ✔
   b) delete Placeholder block ✔
   c) assign the Placeholder block a content type (ie. image) ✔

No Issues found

Catalyst QA ✔

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10138

[Steven (stevens-q)]

Commit hash: 25cbcb467c69b8666744ef9cde46780067d5ce27
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
**********************
1) The following users exist
a) Mahara user (no roles)
b) Institution admin
c) Institution staff
2) All users have profiles completed to at lease 50%
3) All users have journals with entries, Plans with tasks and Resume's filled in

TEST STEPS: Mahara user create portfolio page using placeholder block functionality
************************************************************************************
Placeholder block testing - add to page
1) Verify user can drag Placeholder block icon (+) to page column ✔
2) Verify that user can click Placeholder block icon (+) and add placeholder through Addblock modal ✔
3) Add page to time line
4) Ammend page - add 2 more modal and add page to time line
5) View the time line
6) Verify that the timeline shows a progression of the page and verify that the blocks are displayed in correct positions ✔
7) Edit place holder block and add page to time line
8) Delete Placeholder block and add page to time line
9) Verify that the timeline shows a progression of the page and verify that the blocks are displayed in correct positions ✔

Export page as HTML file
1) Export page as HTML file
2) save the zip file on local drive
3) Open the index page in a browser
4) Verify that the blocks are displayed as in the original page ✔

Export page as Leap2a
1) Export the page as a leap2a file
2) save the zip file on local drive
3) log into the site as another user and import the leap2a file
4) Verify that the page is now displayed in your portfolio and is displayed as in the original page ✔
5) Verify that the user can edit the Placeholder block ✔
   a) move the Placeholder block ✔
   b) delete Placeholder block ✔
   c) assign the Placeholder block a content type (ie. image) ✔

Copy Page with Placeholder blocks
1) User share with public and allow copying
2) Log in as another user and copy the public page that was shared
3) As the other user edit an existing block (Image) and replace with another image
4) Verify that the page has successfully been changed ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10042
Committed: https://git.mahara.org/mahara/mahara/commit/62e432fb8194fb0f6f43f166131e2ec409cb6e10
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 62e432fb8194fb0f6f43f166131e2ec409cb6e10
Author: Robert Lyon <email address hidden>
Date: Fri May 24 15:15:50 2019 +1200

Bug 1829940: Create plugin base config form / system

And create a form for the blocktype class
Allow the blocktype_installed to have a sort order

behatnotneeded

Change-Id: I2e11274a36dba59dfc193b2f5b504303a7e21a54
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10040
Committed: https://git.mahara.org/mahara/mahara/commit/4d9a564560ffcef48f3d98d773d0ebd11f2f4289
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 4d9a564560ffcef48f3d98d773d0ebd11f2f4289
Author: Robert Lyon <email address hidden>
Date: Fri May 24 11:39:43 2019 +1200

Bug 1829940: Restrict the chooser to one 'add' button

Done in this patch:
- restricted the list to one shortcut button (the placeholder one)
- cleaned up old code where one could edit the block on the without
modal
- moved the button to be above content layout and next to the
instructions section
- move the block help link to within placeholder block and be an 'i'
on 'Content types' heading

behatnotneeded

Change-Id: I8a85842ffef5e50c62aca73a4b33c22579b160ca
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10138
Committed: https://git.mahara.org/mahara/mahara/commit/25cbcb467c69b8666744ef9cde46780067d5ce27
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 25cbcb467c69b8666744ef9cde46780067d5ce27
Author: Robert Lyon <email address hidden>
Date: Mon Jul 1 08:14:16 2019 +1200

Bug 1829940: Make placeholder blocktype be active by default

And stop it from being deactivated

behatnotneeded

Change-Id: I26adfb9cff0ffa6f189b44b634ae04f6641a9ced
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10070
Committed: https://git.mahara.org/mahara/mahara/commit/51af094be8aecf48e2f72d672e0556dbf266cbc5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 51af094be8aecf48e2f72d672e0556dbf266cbc5
Author: Robert Lyon <email address hidden>
Date: Fri Jun 7 11:52:02 2019 +1200

Bug 1829940: Move 'add placeholder' to float on right

Done in this patch: -
- have the add block button on right
- have text on large screens but only icon on smaller screens

behatnotneeded

Change-Id: I37b6a8e44036d2d9a43b25700c3f1812f94c9a81
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10035
Committed: https://git.mahara.org/mahara/mahara/commit/0f8d5b314c4fde06474a70d38aa87b47581028c9
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 0f8d5b314c4fde06474a70d38aa87b47581028c9
Author: Robert Lyon <email address hidden>
Date: Tue May 21 12:37:10 2019 +1200

Bug 1829940: Placeholder block

This patch does the following:
- Create new blocktype 'placeholder'
- Make sure it is copyable
- Make sure it is versionable
- Allow tags for it and that it works with create page via tags
- Populate instance config with content types using 'showmore' pagination

behatnotneeded

Change-Id: I8437fbab587b5dc8661512ce8d227161f0129475
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10038
Committed: https://git.mahara.org/mahara/mahara/commit/882259ee497afd4d196cd6d3675da3e29275fdba
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 882259ee497afd4d196cd6d3675da3e29275fdba
Author: Robert Lyon <email address hidden>
Date: Wed May 22 13:46:18 2019 +1200

Bug 1829940: Placeholder option update page with block of choice

This patch does the following:
- Make 'placeholder' configure options clickable so that on clicking
an option updates the block on the page and changes the configure form
to the form of the blocktype chosen
- On 'add placeholder' -> 'choose option' we have 'remove' option on
form and it removes the block from the page
- On 'add placeholder' -> 'save' -> 'configure block' -> 'choose option'
we have 'cancel' option on form and it reverts the block back to
'placeholder'

behatnotneeded

Change-Id: I1681ef92c5ccc14cda2167a040bb751501bfdbcd
Signed-off-by: Robert Lyon <email address hidden>