Changing the display name of the site shouldn't break the SAML private key pass

Bug #1829108 reported by Robert Lyon
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

If we change the site name for a site that uses SAML it breaks the ability to login via SAML

We can roll the certificates and delete old ones to fix this problem but it means the IdPs will need to update their info about the SP certificate so no one can log in until this is done.

We should have a static SAML private key that is part of the saml auth plugin rather than rely on site name

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Dmitrii Metelkin (dmitriim) wrote :

Moodle has a specific setting for that password and it invalidates certificates when you change it. Also there is a proper description for users. Looks like we should go the same way.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11038

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11038
Committed: https://git.mahara.org/mahara/mahara/commit/a795d53266563f847eda2e4e09d9459cdaad5cf5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a795d53266563f847eda2e4e09d9459cdaad5cf5
Author: Robert Lyon <email address hidden>
Date: Tue Jun 23 17:30:58 2020 +1200

Bug 1829108: Allow saml auth admin to set private key passphrase

Rather than just relying on the site name

Change-Id: I06e007b5a0ebe6f4dc7159ae3d60f6050c981828
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 20.10.0
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.